Bug 21096 - small bug in xplanet when compiled with gcc 3.x - no satellite details
Bug#: 21096 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: bug-wranglers@gentoo.org Reported By: gentoo@inrevo.com
Component: Applications
URL: 
Summary: small bug in xplanet when compiled with gcc 3.x - no satellite details
Keywords:  
Status Whiteboard: 
Opened: 2003-05-16 06:40 0000
Description:   Opened: 2003-05-16 06:40 0000
I spoke to the author of xplanet some time ago about this. I patched my own 
copy, now I'm building my new machine and wished I'd told gentoo.

There is a bug in xplanet when compiled with gcc 3.x. This is as the gcc 
developers chose to change their interpretation of the standard - see http:
//gcc.gnu.org/onlinedocs/libstdc++/faq/index.html#4_4 

The fix is simple, in the words of the author:
> At line 549 in
> libannotate/drawSatellite.cc try putting
> infile.clear();
> just after
> infile.close();

Without this no satellite trails are shown. 

Reproducible: Always
Steps to Reproduce:
0. using gcc 3.x emerge xplanet
1. run xplanet with a valid satellite file : e.g. xplanet -satfile science, 
while under X. 
2. Look for a trail across the map - there won't be one 
3. apply patch and rebuild 
4. repeat 1
5: repeat 2 and see pretty trail of the iss

Actual Results:  
just a map, no satellite trail or image

Expected Results:  
trail and icon of the ISS

------- Comment #1 From Alistair McDonald 2003-05-21 15:07:19 0000 -------
I should say that I think all it needs is a tiny patch file. I don't know
enough about patching, but I'm sure there are gentoo developers who do,and can
develop this. There would be no harm in using the patch on gcc 2.9x systems
too, lookign at the code. 

------- Comment #2 From Jukka Palko 2003-08-20 21:44:29 0000 -------
Personally I had the problem that xplanet 0.94-r1 did not make any satellite
information with the following command to the output image: "xplanet -satfile
visible-satellites -output test.jpg". I was in contact with Hari Nair and he
replied saying that he has placed an updated version (0.95a) of the old
xplanet on the xplanet web page. Using this version the satellite images work
perfectly.

Reason why I am staying at 0.9x versions is that Hans Ecke's really handy
scripts (http://hans.ecke.ws/xplanet/) work only with 0.9x versions as at the
moment. He has though mentioned on his web pages that once he has time, he will
make them work with 1.x. :)

------- Comment #3 From SpanKY 2003-09-11 18:55:04 0000 -------
i added the patch to 0.94, sorry for the delay

------- Comment #4 From Thomas Worthington 2003-09-13 11:27:56 0000 -------
alpha root # emerge xplanet
Calculating dependencies ...done!
>>> emerge (1 of 1) x11-misc/xplanet-0.94-r1 to /
>>> md5 src_uri ;-) xplanet-0.94.tar.gz
>>> Unpacking source...
>>> Unpacking xplanet-0.94.tar.gz to /var/tmp/portage/xplanet-0.94-r1/work

 * Cannot find $EPATCH_SOURCE!  Value for $EPATCH_SOURCE is:
 * 
 *   /usr/portage/x11-misc/xplanet/files/0.94-gcc3.patch


!!! ERROR: x11-misc/xplanet-0.94-r1 failed.
!!! Function epatch, Line 214, Exitcode 0
!!! Cannot find $EPATCH_SOURCE!

Looks like the patch is not in as of 13th September 2003

------- Comment #5 From SpanKY 2003-09-13 12:30:35 0000 -------
now on cvs ... dunno what happened there, my apologies