Bug 210904 - >=dev-lang/lua-5.1.3-r1 : sieve.lua test fails, patch provided
Bug#: 210904 Product:  Gentoo Linux Version: 2007.0 Platform: AMD64
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: mabi@gentoo.org Reported By: oli.huber@gmail.com
Component: Ebuilds
URL: 
Summary: >=dev-lang/lua-5.1.3-r1 : sieve.lua test fails, patch provided
Keywords:  
Status Whiteboard: 
Opened: 2008-02-20 17:19 0000
Description:   Opened: 2008-02-20 17:19 0000 
the sieve test fail because math.mod seems to be depreciate : in src/luaconf.h
: 
 /*
@@ LUA_COMPAT_MOD controls compatibility with old math.mod function.
** CHANGE it to undefined as soon as your programs use 'math.fmod' or
** the new '%' operator instead of 'math.mod'.
*/
#undef LUA_COMPAT_MOD

So I replace math.mod with math.fmod in the test.

------- Comment #1 From Olivier Huber 2008-02-20 17:21:00 0000 ------- 
Created an attachment (id=144135) [details]
replace math.mod with math.fmod in test/sieve.lua

------- Comment #2 From Olivier Huber 2008-02-20 17:21:53 0000 ------- 
Created an attachment (id=144136) [details]
ebuild's diff

------- Comment #3 From Olivier Huber 2008-02-21 19:41:27 0000 ------- 
Created an attachment (id=144257) [details]
lua.ebuild.patch

In fact we need to patch only if use=deprecated is not enable.

------- Comment #4 From Jeroen Roovers 2008-05-15 18:29:42 0000 ------- 
It would also be nice if we got rid of the ridiculous &> /dev/null in
src_test(). If anything you'd want to _keep_ the output of a test, especially
if it fails. Frankly, why anyone would ever put &> /dev/null in an ebuild is
beyond me.

Changing the summary as this hasn't been fixed in -r2.

------- Comment #5 From Matti Bickel 2008-05-16 16:14:30 0000 ------- 
Probably the &> /dev/null was introduced so the output looked nicer or
whatever. I agree with you that it's silly, i removed it and included the patch
for the test. Thanks Oliver!