Bug 210110 - ~net-misc/openssh-4.7_p1: LPK fix for 64-bit Linux
Bug#: 210110 Product:  Gentoo Linux Version: unspecified Platform: AMD64
OS/Version: Linux Status: RESOLVED Severity: major Priority: P2
Resolution: FIXED Assigned To: robbat2@gentoo.org Reported By: socrtp-gentoo@soclab.eu.org
Component: Ebuilds
URL: 
Summary: ~net-misc/openssh-4.7_p1: LPK fix for 64-bit Linux
Keywords:  
Status Whiteboard: 
Opened: 2008-02-14 10:05 0000
Description:   Opened: 2008-02-14 10:05 0000 
The OpenSSH-LPK patch is broken on x86_64 linux. I've written a patch that fix
this problem and sent it to LPK patch developer. Anyway it would be nice to
have this issue fixed in Gentoo before the new version of the patch will be
released.


Reproducible: Always

------- Comment #1 From Piotr Stolc 2008-02-14 10:07:52 0000 ------- 
Created an attachment (id=143480) [details]
Patch that makes LPK working on 64-bit Linux

------- Comment #2 From Piotr Stolc 2008-02-14 10:09:10 0000 ------- 
Created an attachment (id=143482) [details]
Patch for openssh-4.7_p1-r1.ebuild

------- Comment #3 From Robin Johnson 2008-02-23 06:17:39 0000 ------- 
Could you please state what is actually broken with this?
Gentoo Infra has openssh-4.7_p1-r1 LPK running and in production use on several
amd64 machines, and we haven't seen any problems.

------- Comment #4 From Piotr Stolc 2008-02-23 10:16:28 0000 ------- 
The problem is with length of time_t type (it is long - 4 bytes on 32-bit and 8
bytes on 64-bit archs). LPK uses OpenSSH routine to parse config file and it
converts timelimit strings to int using atoi(). Well, this should not be a
problem since time_t should be unsigned value and the timeout setting would
just not work, but there is probably a "signed/unsigned" bug in OpenLDAP (tried
2.3.38 and 2.3.40) and in my case the client abandons the connection
immediately and LPK does not work correctly. And here is my fix for this :)

------- Comment #5 From SpanKY 2008-03-29 03:07:13 0000 ------- 
added fix to openssh-4.7_p1-r5