Summary: | media-sound/timidity++-2.13.2-r10: Changes to desktop file etc. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | D.Allain |
Component: | [OLD] KDE | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | reavertm |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ebuild
desktop file ebuild patch desktop file patch |
Description
D.Allain
2008-01-24 19:41:20 UTC
uh, .desktop files should be installed into /usr/share/applications as per freedesktop.org standard I dont quite understand what you're suggesting. Is that a desktop entry ? why in a kde specific dir then ? timidity has several interfaces, so why -ia ? cc'ing kde, as I dont know much about it but I thought installing .desktop files in the suggested location was deprecated (In reply to comment #2) > cc'ing kde, as I dont know much about it but I thought installing .desktop > files in the suggested location was deprecated It is. Samuli is right. (In reply to comment #1) > uh, .desktop files should be installed into /usr/share/applications as per > freedesktop.org standard I am not an expert on directory standards, so I guess you are right. +*timidity++-2.13.2-r10 (13 May 2009) + + 13 May 2009; Samuli Suominen <ssuominen@gentoo.org> + +timidity++-2.13.2-r10.ebuild, +files/timidity.desktop, + +files/timidity.xpm: + Install desktop entry and icon wrt #207311. I don't want to file new bug report for it. Current solution unconditionally install .desktop menu entry even when it may not work at all (X use flag disabled) - not mentioning that it forces Xaw GUI client even when Gtk2 one is available. Besides Xaw dependencies are missing, WORKDIR is not quoted. Removing kde herd from CC - it has nothing to do with us whatsoever. Proposed ebuild patch will follow however: - use best available interface client in .desktop file - show desktop icon only when non-terminal interface is available (as ncurses, slang and dummy - they require .midi file as argument so no point in menu item for them) - added libXaw, libXext deps for X use flag - reordered deps alphabetically - added quoting to some variables I don't have means to test tcl/tk client so I haven't added this one. Created attachment 193353 [details]
ebuild
Created attachment 193355 [details]
desktop file
Post a diff against current desktop file and ebuild instead, i'm not going to start comparing them like this. Created attachment 193420 [details, diff]
ebuild patch
Created attachment 193422 [details, diff]
desktop file patch
(In reply to comment #10) > Created an attachment (id=193420) [edit] > ebuild patch > ebuild patch is unacceptable, it adds unnecessary quoting to bash assigments all over the place.. Fine, let it rot then. - Current ebuild is broken, because it doesn't handle spaces in WORKDIR (WORKDIR is path so *must* be quoted). - use X implementation is broken when no libX11 and libXext is present on sustem - installed .desktop icon is useless (doesn't work at all) when no bitmap fonts are installed (it's rendered by Xaw, doesn't make use of freetype) But of course minimal quoting in bash assignments is the most important. + 24 Jul 2009; Samuli Suominen <ssuominen@gentoo.org> + +timidity++-2.13.2-r11.ebuild, +files/conf.d.timidity.2, + +files/timidity.desktop.2: + LADSPA_PATH is now configurable from inside conf.d/timidity wrt #204713, + thanks to Adam Nielsen. Revert -polling.patch since it breaks realtime + playing with FluidR3 soundfont wrt #275198. Desktop entry now prefers GTK+ + frontend if available wrt #207311. |