Bug 207220 - app-portage/elogviewer doesn't sort the entries by year
Bug#: 207220 Product:  Portage Development Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: fauli@gentoo.org Reported By: ekz999@gmail.com
Component: Third-Party Tools
URL: 
Summary: app-portage/elogviewer doesn't sort the entries by year
Keywords:  
Status Whiteboard: 
Opened: 2008-01-23 21:08 0000
Description:   Opened: 2008-01-23 21:08 0000 
elogviewer entries are sorted in a day rather than a year, because of the
syntax of date (dd/mm/yyyy) (see attached image)

elogviewer version: 0.5.2

Reproducible: Always

Steps to Reproduce:
1. run elogviewer
2. click on 'Time' column, to sort by date


Actual Results:  
The dates are sorted per day

Example (dd/mm/yy):

06/12/07
07/01/08
07/08/07


Expected Results:  
The dates are sorted per year and month

Example (dd/mm/yy):

07/08/07
06/12/07
07/01/08

------- Comment #1 From ekz 2008-01-23 21:09:47 0000 ------- 
Created an attachment (id=141677) [details]
Bad-Sorted entries

------- Comment #2 From Christian Faulhammer 2008-01-23 21:38:38 0000 ------- 
adding author...Mathias, please have a look.

------- Comment #3 From Jouni Kosonen 2008-01-23 22:10:19 0000 ------- 
Created an attachment (id=141684) [details]
Separation of localized tstamp display from the sort key

I think that the solution is something like this: show the LC_TIME formatted
timestamp but sort by the YYYY-MM-DD hh:mm:ss formatted version.

I may have made a slight mistake somewhere in there, but with this modification
the sorting works with fi_FI, ja_JP, en_US and POSIX locales as expected.

------- Comment #4 From ekz 2008-01-23 23:00:07 0000 ------- 
(In reply to comment #3)
> Created an attachment (id=141684) [edit] [details]

The patch works OK, thanks

------- Comment #5 From Christian Faulhammer 2008-01-24 08:20:21 0000 ------- 
(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=141684) [edit] [details]
> 
> The patch works OK, thanks

 From me, too. :)  My Python skills are somewhat crippled, so if you are bored,
Jouni, you can have a look at bug 195429, which bothers me a bit.  Committed as
-r1.  Thanks everyone.