Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 205489

Summary: [java-overlay] dev-java/hamcrest should be split to subpackages
Product: Gentoo Linux Reporter: Vlastimil Babka (Caster) (RETIRED) <caster>
Component: [OLD] JavaAssignee: Java team <java>
Status: RESOLVED FIXED    
Severity: normal CC: ercpe, gentoo
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 287760, 287763, 287775, 287777    
Bug Blocks:    
Attachments: New dev-java/hamcrest ebuild
Causes the core target to do nothing
Causes the generator target to do nothing
Causes the integration target to do nothing
Causes the library target to do nothing
Keeps sources from being added to JAR files.
Revised ebuild
Patch of changes from hamcrest-1.1.ebuild in java-overlay.

Description Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2008-01-12 17:06:53 UTC
There are several parts/jars in hamcrest (generator, core, integration...) and IMHO shouldn't be in one package due to deps of the individual parts. Had troubles with junit4 which needs just hamcrest-core, but through full hamcrest it got all those mock packages in deps and transitively ended with junit3 in its classpath. And then running the testrunner in junit4 funily resulted in junit3's testrunner being run :) And there was also the circular dep with FEATURES=test issue. So for junit4, I made a hamcrest-core package in the tree. Internally it also builds and executes hamcrest-generator in its build process (which means a --build-only qdox dep), but does not install it, and I didn't feel like separating hamcrest-generator package just for this, until it's needed as dep also elsewhere.

So, since there's more packages depending on hamcrest in the overlay, we should eventually split it according to what parts the packages really need. The hamcrest in overlay atm does not depend on hamcrest-core in tree, but both build and install hamcrest-core.jar.
Comment 1 Daniel Solano Gómez 2009-10-05 14:39:48 UTC
*** Bug 287781 has been marked as a duplicate of this bug. ***
Comment 2 Daniel Solano Gómez 2009-10-05 14:43:57 UTC
Created attachment 206124 [details]
New dev-java/hamcrest ebuild

This new ebuild should replace the one in java-overlay and relies on the broken up hamcrest-* ebuilds I have submitted.  This particular ebuild provides no new JAR files, but can run the unit tests and install examples.
Comment 3 Daniel Solano Gómez 2009-10-05 14:44:21 UTC
Created attachment 206126 [details, diff]
Causes the core target to do nothing
Comment 4 Daniel Solano Gómez 2009-10-05 14:44:46 UTC
Created attachment 206128 [details, diff]
Causes the generator target to do nothing
Comment 5 Daniel Solano Gómez 2009-10-05 14:45:07 UTC
Created attachment 206129 [details, diff]
Causes the integration target to do nothing
Comment 6 Daniel Solano Gómez 2009-10-05 14:45:24 UTC
Created attachment 206130 [details, diff]
Causes the library target to do nothing
Comment 7 Daniel Solano Gómez 2009-10-05 14:45:56 UTC
Created attachment 206132 [details, diff]
Keeps sources from being added to JAR files.
Comment 8 Daniel Solano Gómez 2009-10-05 17:51:49 UTC
Created attachment 206156 [details, diff]
Revised ebuild

Revised ebuild as it did not declare dependency on dev-java/ant-junit4.
Comment 9 Daniel Solano Gómez 2009-11-03 23:37:09 UTC
Created attachment 209178 [details, diff]
Patch of changes from hamcrest-1.1.ebuild in java-overlay.

Updated patch that:
1. Adds depend on findutils
2. Works with newly split hamcrest-generator
Comment 10 Johann Schmitz (ercpe) (RETIRED) gentoo-dev 2014-03-02 16:27:15 UTC
We have everything in the tree now (see bug #287777):

+  02 Mar 2014; Johann Schmitz <ercpe@gentoo.org>
+  +files/1.1-remove-targets.patch, +files/1.2-remove-targets.patch,
+  +files/1.3-remove-targets.patch, +hamcrest-integration-1.1.ebuild,
+  +hamcrest-integration-1.2.ebuild, +hamcrest-integration-1.3.ebuild,
+  +metadata.xml:
+  New ebuild for hamcrest-integration in all slots (:0, :1.2 and :1.3) wrt bug
+  #287777.  This commit also solves bug #205489.