Bug 205362 - games-fps/quake4-bin: use a tango style png icon instead of current bmp one
Bug#: 205362 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: WONTFIX Assigned To: games@gentoo.org Reported By: pacho@condmat1.ciencias.uniovi.es
Component: Games
URL: 
Summary: games-fps/quake4-bin: use a tango style png icon instead of current bmp one
Keywords:  
Status Whiteboard: 
Opened: 2008-01-11 20:30 0000
Description:   Opened: 2008-01-11 20:30 0000 
Currently, a ugly (at least from my point of view) bmp icon is being used for
menu entry. I suggest download and use a tango style quake4 icon instead. It's
GPL-2 licensed.

I attach a diff to be applied to latest ebuild for this. I have had to modify
"unpack_makeself" command because, if not, it fails because cannot unpack png
icon (I think that "unpack_makeself" should simply ignore it like "unpack"
does, but I don't know how to fix it :-( )

Thanks a lot

Reproducible: Always

------- Comment #1 From Pacho Ramos 2008-01-11 20:30:35 0000 ------- 
Created an attachment (id=140737) [details]
ebuilds.diff

------- Comment #2 From Carsten Lohrke 2008-02-29 21:05:53 0000 ------- 
Actually this isn't an enhancement request, but a bug. The Icon Theme
Specification¹ is pretty clear about which file formats are allowed:

>The image files must be one of the types: PNG, XPM, or SVG, and the extension must be ".png", ".xpm", or ".svg" (lower case). The support for SVG files is optional. Implementations that do not support SVGs should just ignore any ".svg" files. In addition to this there may be an additional file with extra icon-data for each file. It should have the same basename as the image file, with the extension ".icon". e.g. if the icon file is called "mime_source_c.png" the corresponding file would be named "mime_source_c.icon".


[1]
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

------- Comment #3 From Mr. Bones. 2008-02-29 21:56:18 0000 ------- 
No, that only applied if it's not a full path.

------- Comment #4 From Carsten Lohrke 2008-03-01 17:01:35 0000 ------- 
(In reply to comment #3)
> No, that only applied if it's not a full path.

BMP is not a mandated file format, regardless if it's an absolute path or not.

------- Comment #5 From Carsten Lohrke 2008-03-01 17:07:04 0000 ------- 
Eh, o.k. you're right. The desktop entry specification is unspecific about it.
Using any other file type than the ones mandated in the icon theme spec is
still a bad idea.

------- Comment #6 From Chris Gianelloni (RETIRED) 2008-03-04 04:30:15 0000 ------- 
We also use the shipped icon for a reason.  Other icons, even those created by
parties external to id Software, are using id's intellectual property without
any legal justification.  As such, even though the icon file may be GPL-2, the
contents are owned by another party and cannot be relicensed.

Yes, the BMP is ugly as sin.  Complain to id to ship a PNG.  That being said, I
just hacked up the ebuild to install a PNG icon if it finds one in FILESDIR or
DISTDIR.