Bug 204227 - media-libs/faad2 will not exit if output pipe breaks
Bug#: 204227 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: sound@gentoo.org Reported By: lavajoe@gentoo.org
Component: Library
URL: 
Summary: media-libs/faad2 will not exit if output pipe breaks
Keywords:  
Status Whiteboard: 
Opened: 2008-01-04 01:17 0000
Description:   Opened: 2008-01-04 01:17 0000
If using the "-w" option in faad and piping to another program, faad will not
exit if the other program quits before faad is done.  This affects music
servers that convert on-the-fly, since if a song is stopped, especially several
times, faad processes will continue to eat CPU cycles until done.  I will
attach the patch.

------- Comment #1 From Joe Peterson 2008-01-04 01:29:19 0000 -------
Created an attachment (id=140008) [details]
files/faad2-2.6.1-broken-pipe.patch

Here is a patch for 2.6.1.

------- Comment #2 From Alexis Ballier 2008-01-05 19:13:48 0000 -------
Please send the patch upstream and ping me once its applied so that I just have
to backport it. They're the ones the most able to review the patches.

------- Comment #3 From Joe Peterson 2008-01-05 19:31:40 0000 -------
OK, emailed - will file a bug there if requested or no response...  Thanks!

------- Comment #4 From Joe Peterson 2008-05-06 18:50:51 0000 -------
(Oops, forgot to send this on when I got it...)
Patch accepted by upstream and in their CVS; should be all set to incorporate. 
Here's email from upstream:

------------- Received by lavajoe on 03/24/2008 ----------
Hi Joe,

Thanks a lot for the patch! I checked it and committed it to CVS. I applied
some more patches this weekend, so I'll wait for some feedback and if
everything is ok now, I will release some new packages.

Best regards,
Menno
-------------

------- Comment #5 From Joe Peterson 2008-05-08 12:08:23 0000 -------
Patch applied in faad2-2.6.1-r1