Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 204007

Summary: media-libs/libdlna-0.2.3 - Adding new ebuild.
Product: Gentoo Linux Reporter: jacques hullu <jacques.hullu>
Component: New packagesAssignee: Jeremy Olexa (darkside) (RETIRED) <darkside>
Status: RESOLVED FIXED    
Severity: enhancement CC: adeel_n, darkside, jerome.groven, orangewarrior, Sander.Sweers, trajano, xmw
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 192561    
Attachments: updated ebuild
working ebuild in txt format
libavcodec/libavformat fix
working ebuild
changes the #include statements in the source codes
cleaned up ebuild
This is the latest source version of the ebuild
Complete build environment for libdlna-0.2.3
patches ffmpeg/libav{codec|format}.h to libavcodec/avcodec.h and libavformat/avformat.h
EAPI=2, includes libdlna-0.2.3-r1_all_avformat_avcodec.patch
EAPI=2, includes libdlna-0.2.3-r1_all_avformat_avcodec.patch, dependency

Description jacques hullu 2008-01-01 22:55:09 UTC
libdlna aims at being the reference open-source implementation of DLNA (Digital Living Network Alliance) standards.

Reproducible: Always
Comment 1 Adeel 2008-03-16 01:43:53 UTC
From the project description:
libdlna is written in C and relies on FFMPEG librairies (libavformat and libavcodec) to handle and demux A/V streams. You still need libupnp to provide basic UPnP support to your project

The ebuild does not check to see if FFMPEG is installed on the host system, otherwise, compilation fails. Included is an updated ebuild
Comment 2 Adeel 2008-03-16 01:47:01 UTC
Created attachment 146261 [details]
updated ebuild
Comment 3 Adeel 2008-03-16 02:09:12 UTC
Comment on attachment 146261 [details]
updated ebuild

# Copyright 1999-2008 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $

DESCRIPTION="A reference open-source implementation of DLNA (Digital Living Network Alliance) standards."
HOMEPAGE="http://libdlna.geexbox.org"
SRC_URI="http://libdlna.geexbox.org/releases/$\{P\}.tar.bz2"

LICENSE="GPL-2"
SLOT="0"
KEYWORDS="~x86 ~amd64"
IUSE=""

DEPEND="media-video/ffmpeg"
RDEPEND=""

src_compile() {
        # I can't use econf
        # --host is not implemented in ./configure file
        ./configure \
                --prefix=/usr \
                || die "./configure failed"
        emake || die "emake failed."
}

src_install() {
        emake DESTDIR="$\{D\}" install || die "emake install failed."
        dodoc README FAQ CHANGELOG
     }
}
Comment 4 Adeel 2008-03-16 02:40:46 UTC
Comment on attachment 146261 [details]
updated ebuild

broken ebuild
Comment 5 Adeel 2008-03-16 02:42:31 UTC
Created attachment 146265 [details]
working ebuild in txt format

added debug USE flag
basic flag filtering (duplicate -O C{XX}FLAGS)
removed annoying rtf filtering (dumb macs)
Comment 6 Adeel 2008-03-17 07:57:14 UTC
i'm willing to become package maintainer if there are no objections
Comment 7 Adeel 2008-04-24 02:56:02 UTC
Created attachment 150783 [details, diff]
libavcodec/libavformat fix

autoconf fails due to ffmpeg headers being installed to a non-expected location in /usr/include. the configure script expects the headers to reside in /usr/include/ffmpeg, rather than in /usr/include/{libavformat,libavcodec}
Comment 8 Adeel 2008-04-24 03:42:21 UTC
Created attachment 150786 [details]
working ebuild

includes the new patches
Comment 9 Adeel 2008-04-24 03:45:59 UTC
Created attachment 150787 [details]
changes the #include statements in the source codes

updates the location for the ffmpeg related header files to the correct locations.
Comment 10 Jeremiah Nolte 2008-05-08 02:24:57 UTC
I had to comment out both patch lines in the ebuild for it to work (x86_64 with ffmpeg 0.4.9_p20070616 installed).
Comment 11 Adeel 2008-05-08 08:11:36 UTC
(In reply to comment #10)
> I had to comment out both patch lines in the ebuild for it to work (x86_64 with
> ffmpeg 0.4.9_p20070616 installed).
> 

I haven't tried it with that ffmpeg version, i used ffmpeg-0.4.9_p20080326 and it built without problems. You may want to double check to ensure that you're transcoding is actually operational, if it's not, try unmasking the latest version of ffmpeg and re-emerging.  I'll re-work the ebuild and add a patch for that specific ffmpeg version or just force the dependancy to the latest ffmpeg, as i'm assuming each ffmpeg version will probably fail a generic patching attempt
Comment 12 Sander Sweers 2008-05-12 22:33:05 UTC
Created attachment 152991 [details]
cleaned up ebuild

Cleaned up ebuild. Not sure why you patch for different include locations as there *should* not be a ffmpeg that install in an other place then /usr/include/ffmpeg.

Changelog
* move myconf defaults to top of src_compile and add options as we go
* remove include patches ( remove the whole src_unpack ) as it is not needed
* Fix --libdir to use get_lib so it installs on AMD64 in /usr/lib64
* add the test use value to run make test ( not sure if you/we/me want to keep this )
* Fix dodoc, there is no FAQ and ChangeLog was misspelled
* Remove cflag filter. why does it need a filter?
Comment 13 Archimedes Trajano 2008-06-16 02:54:47 UTC
The build requires the etags command which seems to be in virtual/emacs
Comment 14 Archimedes Trajano 2008-06-16 02:58:09 UTC
Created attachment 157027 [details]
This is the latest source version of the ebuild

This pulls the latest code from their mercurial repository.
Comment 15 Lukasz Ligowski 2008-07-20 16:38:39 UTC
Sanders, you're wrong about ffmpeg. I use ffmpeg-0.4.9_p20080326 on amd64 and it puts it's headers into /usr/include/libavutil and similar directories
Comment 16 Seri Al-Najjar 2008-12-18 17:08:23 UTC
Created attachment 175757 [details]
Complete build environment for libdlna-0.2.3

Untar into /
It creates a /usr/portage/local/local-overlay directory structure if required

Make sure to edit your make.conf and add the line:
PORTDIR_OVERLAY="/usr/portage/local/local-overlay"

Have tested on both x86 and amd64
Comment 17 Daniel Robbins 2008-12-30 08:44:05 UTC
Added to funtoo portage tree (not the gentoo one):
http://github.com/funtoo/portage/commit/eb16fe58e1b7601b2f24aaf9c3ce7d3e6c12d4d0
Comment 18 Markus Tacker 2009-01-25 13:44:12 UTC
Development is halted.
Website states: "By lack of spare time, motivation and interest, libldna development is currently discontinued (this may change though). Don't expect release anytime soon :-("
Comment 19 Michael Weber (RETIRED) gentoo-dev 2009-09-02 00:06:17 UTC
Guys, now with ffmpeg-0.5-r1 stable, please include the libavcodec/libavformat patches ...

diff -r libdlna-0.2.3.orig/work/libdlna-0.2.3/configure libdlna-0.2.3/work/libdlna-0.2.3/configure
613c613
< check_lib ffmpeg/avformat.h av_register_all -lavformat || die "Error, can't find libavformat !"
---
> check_lib libavformat/avformat.h av_register_all -lavformat || die "Error, can't find libavformat !"
615c615
< check_lib ffmpeg/avcodec.h avcodec_register_all -lavcodec || die "Error, can't find libavcodec !"
---
> check_lib libavcodec/avcodec.h avcodec_register_all -lavcodec || die "Error, can't find libavcodec !"
diff -r libdlna-0.2.3.orig/work/libdlna-0.2.3/src/av_mpeg4_part10.c libdlna-0.2.3/work/libdlna-0.2.3/src/av_mpeg4_part10.c
29c29
< #include <ffmpeg/avcodec.h>
---
> #include <libavcodec/avcodec.h>
diff -r libdlna-0.2.3.orig/work/libdlna-0.2.3/src/av_mpeg4_part2.c libdlna-0.2.3/work/libdlna-0.2.3/src/av_mpeg4_part2.c
29c29
< #include <ffmpeg/avcodec.h>
---
> #include <libavcodec/avcodec.h>
diff -r libdlna-0.2.3.orig/work/libdlna-0.2.3/src/containers.c libdlna-0.2.3/work/libdlna-0.2.3/src/containers.c
7c7
< #include <ffmpeg/avformat.h>
---
> #include <libavformat/avformat.h>
diff -r libdlna-0.2.3.orig/work/libdlna-0.2.3/src/profiles.h libdlna-0.2.3/work/libdlna-0.2.3/src/profiles.h
25,26c25,26
< #include <ffmpeg/avcodec.h>
< #include <ffmpeg/avformat.h>
---
> #include <libavcodec/avcodec.h>
> #include <libavformat/avformat.h>
Comment 20 Michael Weber (RETIRED) gentoo-dev 2009-09-14 02:40:00 UTC
Created attachment 203987 [details, diff]
patches ffmpeg/libav{codec|format}.h to libavcodec/avcodec.h and libavformat/avformat.h

media-video/ffmpeg-5 issue
Comment 21 Michael Weber (RETIRED) gentoo-dev 2009-09-14 02:41:57 UTC
Created attachment 203988 [details]
EAPI=2, includes libdlna-0.2.3-r1_all_avformat_avcodec.patch

media-video/ffmpeg-5 issue

please add to sunrise.
included in http://svn.xmw.de/gentoo-overlay/
Comment 22 Michael Weber (RETIRED) gentoo-dev 2009-09-14 02:57:42 UTC
Created attachment 203989 [details]
EAPI=2, includes libdlna-0.2.3-r1_all_avformat_avcodec.patch, dependency

added dependency >=media-video/ffmpeg-0.5 (matched by current stable).
Previos versions of ffmpeg install libavcodec.h into /usr/include/ffmpeg and no patch is needed.
Comment 23 Wim Muskee 2009-11-11 20:54:52 UTC
compiles on amd64
Comment 24 Peter Volkov (RETIRED) gentoo-dev 2009-12-22 10:53:38 UTC
*** Bug 297872 has been marked as a duplicate of this bug. ***
Comment 25 Peter Volkov (RETIRED) gentoo-dev 2009-12-22 11:04:20 UTC
Thank you guys. Build issue fixed, dep on ffmpeg added, amd64 keyworded.
Comment 26 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-12-23 21:58:29 UTC
*** Bug 294622 has been marked as a duplicate of this bug. ***
Comment 27 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-12-23 22:04:51 UTC
in gentoo-x86 tree.

Big thanks to all the contributors on this bug. You guys are awesome.