Bug 202492 - app-arch/q7z (new ebuild)
Bug#: 202492 Product:  Gentoo Linux Version: 2007.0 Platform: x86
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: maintainer-wanted@gentoo.org Reported By: alessandro.sturniolo@gmail.com
Component: Ebuilds
URL: 
Summary: app-arch/q7z (new ebuild)
Keywords:  EBUILD
Status Whiteboard: 
Opened: 2007-12-16 17:53 0000
Description:   Opened: 2007-12-16 17:53 0000 
A new ebuild for Q7Z application (http://k7z.sourceforge.net/7Z/Q7Z/).

Reproducible: Always

------- Comment #1 From Alessandro 2007-12-16 17:54:42 0000 ------- 
Created an attachment (id=138638) [details]
Q7Z-0.6.3 ebuild

Place on /usr/local/portage/app-arch/Q7Z/Q7Z-0.6.3.ebuild

------- Comment #2 From Bernd Steinhauser 2008-02-18 06:37:22 0000 ------- 
(In reply to comment #1)
This is _so_ wrong.

>inherit eutils toolchain-funcs multilib
Don't inherit eclasses, that you don't need.

>SRC_URI="http://downloads.sourceforge.net/k7z/${PN}-${PV}.tar.bz2"
${PN}-${PV} is the same as ${P}.

>S=${WORKDIR}/${PN}_${PV}
Why do you define it and then don't use it?

>src_compile() {
>	cd ${WORKDIR}/Q7Z/Build
>	make uninstall
This _really_ does _not_ belong here!
>	make clean
This _really_ does _not_ belong here!
>	make || return 1
Please use emake if possible and if not add a comment about that. Don't use
return, instead add a die message.

>src_install() {
>	cd ${WORKDIR}/Q7Z/Build
>	make install DESTDIR="${D}"
Please use emake if possible and if not add a comment about that.

------- Comment #3 From Bernd Steinhauser 2008-02-18 06:39:30 0000 ------- 
Created an attachment (id=143850) [details]
An ebuild that is a little bit cleaner.

------- Comment #4 From Ben de Groot 2008-02-18 23:36:21 0000 ------- 
I was already working on an ebuild for this. Available in your rsync mirror
shortly ;-)