Bug 200659 - app-accessibility/dasher-4.6.1 - compile error with sys-libs/glibc-2.5
Bug#: 200659 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: gnome@gentoo.org Reported By: jer@gentoo.org
Component: Applications
URL: 
Summary: app-accessibility/dasher-4.6.1 - compile error with sys-libs/glibc-2.5
Keywords:  
Status Whiteboard: 
Opened: 2007-11-28 16:59 0000
Description:   Opened: 2007-11-28 16:59 0000
DasherViewSquare.cpp: In member function ‘Dasher::myint
Dasher::CDasherViewSquar
e::CustomIDiv(Dasher::myint, Dasher::myint)’:
DasherViewSquare.cpp:805: error: ‘lldiv’ is not a member of ‘std’

The fix appears to be something like this:

--- Src/DasherCore/DasherViewSquare.cpp. 2007-10-15 15:55:00.000000000 +0200
+++ Src/DasherCore/DasherViewSquare.cpp  2007-11-28 17:18:08.000000000 +0100
@@ -802,7 +802,7 @@
   else
     return quot;
 #else
-  lldiv_t res = __gnu_cxx::lldiv(iNumerator, iDenominator);
+  lldiv_t res = lldiv(iNumerator, iDenominator);

   if(res.rem < 0)
     return res.quot - 1;


I tested it and it works. Using the __gnu_cxx namespace is dubious as is, so
maybe upstream might like it as well.


---
Wed Nov 28 17:57:28 CET 2007
Portage 2.1.4_rc3 (default-linux/hppa/2007.0, gcc-4.1.2, glibc-2.5-r4,
2.6.23-gentoo-r1-JeR parisc)
=================================================================
System uname: 2.6.23-gentoo-r1-JeR parisc PA8700 (PCX-W2)
Timestamp of tree: Wed, 28 Nov 2007 05:16:01 +0000
distcc 2.18.3 hppa2.0-unknown-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
ccache version 2.4 [disabled]
app-shells/bash:     3.2_p17
dev-lang/python:     2.4.4-r6
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 2.0.0_rc6
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="hppa"
CBUILD="hppa2.0-unknown-linux-gnu"
CFLAGS="-O2 -pipe -mschedule=8000 -march=2.0 -ggdb -Wall"
CHOST="hppa2.0-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /var/bind
/var/spool/torque/sched_priv/{holidays,resource_group,dedicated_time,sched_config}
/var/spool/torque/{server_name,pbs_environment}
/var/www/localhost/htdocs/wordpress/wp-config.php"
CONFIG_PROTECT_MASK="/etc/env.d /etc/fonts/fonts.conf /etc/gconf
/etc/gentoo-release /etc/php/apache2-php5/ext-active/
/etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild
/etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe -mschedule=8000 -march=2.0 -ggdb -Wall"
DISTDIR="/keeps/gentoo/distfiles"
FEATURES="autoaddcvs buildpkg cvs distlocks fixpackages notitles sandbox
sfperms splitdebug strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.snt.utwente.nl/pub/os/linux/gentoo
http://mirror.muntinternet.net/pub/gentoo/ http://gentoo.tiscali.nl/"
LC_ALL="en_US.UTF-8"
LINGUAS="en nl he"
MAKEOPTS="-j4"
PKGDIR="/keeps/gentoo/packages/elmer"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude=/distfiles --exclude=/local --exclude=/packages
--filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/mnt/alt/portage-tmp"
PORTDIR="/keeps/gentoo/portage"
PORTDIR_OVERLAY="/keeps/gentoo/local"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="7zip X Xaw3d a52 aac aalib accessibility acl alsa amr amrnb amrwb ao aoss
apache2 ares arts asf audiofile avfs bash-completion berkdb bidi bitmap-fonts
bittorrent bl bzip2 c++ cairo caps catalogs cdb cddb cdparanoia cdr chardet cjk
cli cpudetection cracklib crypt cups curl custom-cflags dbtool dbus
device-mapper dga dia directfb djbfft domainkeys dts dv dvd dvdr dvdread dxr3
edl elf emacs enca encode esd examples exif expat fam fame fastbuild fastcgi
fbcon ffmpeg filter flac fontconfig foomaticdb fortran ftp gadu gd gdbm geoip
ggi gif gimp gimpprint glep glib glitz glut gmp gnome gnutls gphoto2 gpm gs gsl
gtk gtk2 gtkhtml hal hesiod hppa ical icecast iconv idea idn imagemagick imlib
immqt-bc inquisitio ipv6 isdnlog jack javascript jingle jpeg jpeg2k kde
kerberos lapack lcms ldap leim libcaca libnotify libsamplerate libwww logrotate
logwatch lua lzo mad matroska memcache mhash midi mikmod mmap mng modplug motif
mozbranding mp3 mssql mudflap musepack mysql nas ncurses netpbm network-cron
nfconntrack nfs nls nntp nptl nptlonly nsplugin offensive ogg openexr opengl
openmp oss ots overlays pam pango pbs pch pcre pdf pdo-external perl php pic
plotutils plugins png portage portaudio postgres povray ppds pppd pulseaudio
python pyzord qdbm qt3 qt3support raw readline recode reflection rpc rrdtool
rtc ruby samba sasl scanner scim sdl seamonkey session sid slang slp sndfile
snmp soundex speex spell spl sqlite ssl startup-notification suhosin svg sysfs
talkfilters tcl tcpd tga theora threads thunar-vfs tidy tiff timidity tk tools
truetype truetype-fonts twolame type1-fonts udev unicode unzip urandom usb
userlocales utempter utf v4l v4l2 vanim vcd vidix vim-syntax vorbis wavpack
webdav webinstall wlan wma wmf xanim xattr xchattext xcomposite xface xml xml2
xmpi xorg xpm xrandr xscreensaver xsettings xulrunner xv xvid xvmc zip
zip-external zlib" ALSA_CARDS="ad1889 usb-audio" ALSA_PCM_PLUGINS="adpcm alaw
asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa
lfloat linear meter mulaw multi null plug rate route share shm softvol"
ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev joystick" KERNEL="linux"
LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses
text" LINGUAS="en nl he" USERLAND="GNU" VIDEO_CARDS="stifb fbdev matrox"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LDFLAGS,
PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

------- Comment #1 From Jeroen Roovers 2007-11-28 17:20:08 0000 -------
I cannot stabilise dasher for hppa without this bug being resolved, so I cannot
stabilise gnome-2.20 before this bug is resolved.

------- Comment #2 From Gilles Dartiguelongue 2007-11-28 21:37:06 0000 -------
svn head removed the __gnu_cxx part before ::

I wonder why upstream wants the c++ version over the c one but...
Could you test the compilation of dasher when removing __gnu_cxx ?
If it doesn't work, I have the patch ready to commit to portage.

------- Comment #3 From Jeroen Roovers 2007-11-29 04:43:05 0000 -------
(In reply to comment #2)
> svn head removed the __gnu_cxx part before ::
> 
> I wonder why upstream wants the c++ version over the c one but...
> Could you test the compilation of dasher when removing __gnu_cxx ?
> If it doesn't work, I have the patch ready to commit to portage.

Er, I don't get this. I supplied the patch to make it work in this bug:

-  lldiv_t res = __gnu_cxx::lldiv(iNumerator, iDenominator);
+  lldiv_t res = lldiv(iNumerator, iDenominator);

and I said "I tested it and it works."

So yes, I am waiting for approval to commit this patch and edit the ebuild or
for you to do the very same. :)

------- Comment #4 From Jeroen Roovers 2007-11-29 05:03:02 0000 -------
Anyway, I committed the patched ebuild and the patch and stabilised for HPPA,
as seeing upstream fixing it looks enough like an OK.

------- Comment #5 From Gilles Dartiguelongue 2007-11-29 07:45:07 0000 -------
the point was to check if there was a difference between upstream's fix and
your fix