Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!

Full Text Bug Listing

GCC 4.3 cleans up the include dependencies of the C++ stdlib headers.  The
result is some packages have missing includes.  This patch fixes one such error
in flac-1.2.1-r1.

make[5]: Entering directory
`/var/tmp/portage/media-libs/flac-1.2.1-r1/work/flac-1.2.1/examples/cpp/encode/file'
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../../..  
-DFLaC__INLINE=__inline__ -DNDEBUG -I../../../.. -I./include
-I../../../../include   -O2 -g -march=native -fomit-frame-pointer -pipe -c -o
main.o main.cpp
main.cpp: In function 'int main(int, char**)':
main.cpp:75: error: 'memcmp' was not declared in this scope
make[5]: *** [main.o] Error 1

Created an attachment (id=136308) [details]
flac-1.2.1-gcc-4.3-includes.patch

http://sourceforge.net/tracker/index.php?func=detail&aid=1834168&group_id=13478&atid=313478

applid for 1.2.1-r2, thanks

it's currently masked but only for the time I add the checks for flac++

As the reporter mentiones "This patch fixes ONE such error in flac-1.2.1-r1.".

There is another missing include in examples/cpp/decode/file/main.cpp, patch
follows.

Please reopen.

Created an attachment (id=165420) [details]
the updated patch

(In reply to comment #4)
> As the reporter mentiones "This patch fixes ONE such error in flac-1.2.1-r1.".
> 
> There is another missing include in examples/cpp/decode/file/main.cpp, patch
> follows.
> 
> Please reopen.

 Sound team, please check.

make[4]: Entering directory
`/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode'
Making all in file
make[5]: Entering directory
`/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode/file'
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../../..  
-DFLaC__INLINE=__inline__ -DNDEBUG -I../../../.. -I./include
-I../../../../include   -O2 -march=core2 -mcx16 -msahf --param l1-cache-size=32
--param l1-cache-line-size=64 -mtune=core2 -pipe -Wall -ggdb -c -o main.o
main.cpp
main.cpp: In member function ‘virtual void
OurDecoder::metadata_callback(const FLAC__StreamMetadata*)’:
main.cpp:181: warning: format ‘%llu’ expects type ‘long long unsigned
int’, but argument 3 has type ‘FLAC__uint64’
/bin/sh ../../../../libtool --tag=CXX   --mode=link x86_64-pc-linux-gnu-g++ 
-O2 -march=core2 -mcx16 -msahf --param l1-cache-size=32 --param
l1-cache-line-size=64 -mtune=core2 -pipe -Wall -ggdb  -Wl,--as-needed -o
example_cpp_decode_file main.o ../../../../src/libFLAC++/libFLAC++.la
../../../../src/libFLAC/libFLAC.la -L/usr/lib -logg -lm
libtool: link: x86_64-pc-linux-gnu-g++ -O2 -march=core2 -mcx16 -msahf --param
l1-cache-size=32 --param l1-cache-line-size=64 -mtune=core2 -pipe -Wall -ggdb
-Wl,--as-needed -o .libs/example_cpp_decode_file main.o 
../../../../src/libFLAC++/.libs/libFLAC++.so -L/usr/lib
/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/src/libFLAC/.libs/libFLAC.so
../../../../src/libFLAC/.libs/libFLAC.so /usr/lib64/libogg.so -lm
make[5]: Leaving directory
`/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode/file'
make[5]: Entering directory
`/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode'
make[5]: Nothing to be done for `all-am'.
make[5]: Leaving directory
`/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode'
make[4]: Leaving directory
`/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode'

IOW, fixed.