Bug 199387 - sys-kernel/openvz-sources-028.047 build failure
Bug#: 199387 Product:  Gentoo Linux Version: unspecified Platform: AMD64
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: pva@gentoo.org Reported By: drobbins@funtoo.org
Component: Ebuilds
URL: 
Summary: sys-kernel/openvz-sources-028.047 build failure
Keywords:  
Status Whiteboard: 
Opened: 2007-11-16 19:49 0000
Description:   Opened: 2007-11-16 19:49 0000
Modules build failure with openvz-sources-028.047:

localhost linux # make modules
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CC [M]  kernel/cpt/cpt_net.o
kernel/cpt/cpt_net.c: In function 'cpt_dump_iptables':
kernel/cpt/cpt_net.c:365: error: 'struct ve_struct' has no member named
'_iptables_modules'
make[2]: *** [kernel/cpt/cpt_net.o] Error 1
make[1]: *** [kernel/cpt] Error 2
make: *** [kernel] Error 2


Reproducible: Always




See attached kernel config.

------- Comment #1 From Daniel Robbins 2007-11-16 19:50:28 0000 -------
Created an attachment (id=136104) [details]
Kernel config that triggered build failure (amd64)

------- Comment #2 From Daniel Robbins 2007-11-16 22:03:12 0000 -------
I fixed this build failure by editing include/linux/ve.h and removing the
"#ifdef" / "#endif" from the following part of the code. This solves the build
failure but I can't vouch for the functionality of the iptables bits in openvz
until we get some word from an openvz developer as to their status.

#ifdef CONFIG_VE_IPTABLES
/* core/netfilter.c virtualization */
       void                    *_nf_hooks;
       struct xt_table         *_ve_ipt_filter_pf; /* packet_filter struct */
       struct xt_table         *_ve_ip6t_filter_pf;
       struct xt_table         *_ipt_mangle_table;
       struct xt_table         *_ip6t_mangle_table;
       struct list_head        _xt_tables[NPROTO];

       __u64                   _iptables_modules;
       struct ve_ip_conntrack  *_ip_conntrack;
#endif /* CONFIG_VE_IPTABLES */

------- Comment #3 From Peter Volkov 2007-11-17 19:53:18 0000 -------
Seems that this bug is fixed in new version. I need some time to test it and
will bump it after that. Currently I've put ebuild here. It has one know for me
problem, wrong extraversion, but I'll fix it soon:
http://overlays.gentoo.org/dev/pva/browser/sys-kernel/openvz-sources

------- Comment #4 From Daniel Robbins 2007-11-18 03:14:58 0000 -------
OK, can you incorporate the ati-drivers find_task_by_pid macro fix described in
my comment in bug 181982? Would be cool if we can get this fix in every
openvz-sources kernel moving forward.

------- Comment #5 From Peter Volkov 2007-11-18 07:37:57 0000 -------
Now, 2.6.18.028.049 is in the tree. Note, versioning changed so to emerge this
new version you have to run: 

emerge =sys-kernel/openvz-sources-2.6.18.028.049

I'm going to mark this new kernel stable in next few days, so if you have some
time, please, try it and report everything you encounter.

------- Comment #6 From Daniel Robbins 2007-11-19 15:42:07 0000 -------
(In reply to comment #5)
> Now, 2.6.18.028.049 is in the tree. Note, versioning changed so to emerge this
> new version you have to run: 
> 
> emerge =sys-kernel/openvz-sources-2.6.18.028.049
> 
> I'm going to mark this new kernel stable in next few days, so if you have some
> time, please, try it and report everything you encounter.

OK, tried this new kernel, and no problems so far. I have confirmed that:

1) It compiles cleanly on amd64
2) ati-drivers-8.40.4 builds cleanly against it
3) No iptables modules build issues or other module build issues for my
specific kernel config

I am running this kernel now with ati-drivers. Let me know if you want me to
test anything else.