Summary: | Parallel mkdir failures on Gentoo/FreeBSD. | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | .:deadhead:. <andreamtp+bz> |
Component: | FreeBSD | Assignee: | Gentoo/BSD Team <bsd+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andreaveroni, ar, dav_it, flameeyes, vapier, zephyrus.271 |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | FreeBSD | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch to the ebuld.
eclass/ELT-patches/install-sh/1.5.6 proposed patch eclass/ELT-patches/install-sh/1.5.4 proposed patch eclass/ELT-patches/install-sh/1.5 proposed patch eclass/ELT-patches/install-sh/1.5.4 proposed patch (fixed) |
Description
.:deadhead:.
2007-10-22 18:20:48 UTC
Created attachment 134127 [details, diff]
patch to the ebuld.
With this patch to the ebuild the compile process has been completed succesfully.
Forcing -j1 did the trick.
I've fixed this by adding an elibtoolize patch instead (install-sh-1.5.6) which is also fix other packages that use this libtool version. Thanks! Why was the -j1 dropped in gmp-4.2.2.ebuild? (that was supposed to go in one message...) It still fails here, on gentoo/fbsd7/amd64, with the same error message. It's still broken. Reopening. CC'ing toolchain: Could you please re-add -j1 to the ebuild so that this builds for us? :) no. find the problem, dont ignore it. Change summary to mark some other bugs duplicate of this one. *** Bug 206495 has been marked as a duplicate of this bug. *** Created attachment 157713 [details, diff]
eclass/ELT-patches/install-sh/1.5.6 proposed patch
Looking at the install-sh script that comes with gmp, it does take care of concurrent mkdirs failures (which is what's happening here) but only when installing normal files (when it emulates the mkdir -p), not when installing dirs (install-sh -d)
The patch, changes the check for the previously existing dir (which doesn't *always* work) to capture the mkdir failure (as it's done when installing normal files) and only throw it if the directory was not created.
In this regard, gettext would need an elibtoolize too.
Created attachment 157715 [details, diff]
eclass/ELT-patches/install-sh/1.5.4 proposed patch
And also for the other install-sh patches.
Created attachment 157717 [details, diff]
eclass/ELT-patches/install-sh/1.5 proposed patch
Last one. I'm not sure these 1.5.4 and 1.5 will apply cleanly (just edited the patch, ran an emerge -e world with -j6 where 5 packages failed before).
Please review/test!
Thanks.
Created attachment 157725 [details, diff]
eclass/ELT-patches/install-sh/1.5.4 proposed patch (fixed)
Sorry for the spam, wrong paste on the 1.5.4 one.
install-sh is from automake, not libtool ... so sticking it in with elibtoolize is inappropriate (In reply to comment #14) > install-sh is from automake, not libtool ... so sticking it in with elibtoolize > is inappropriate > That I know, but the auto-magic-patching being done (currently) to try to fix this is coming from ELT-patches. If you like I can make a patch for every version of automake we have and stick an eautoreconf to every ebuild that fails on emake install with -j > 1. Is that what you're asking? i'm not asking anything. i'm saying that overloading elibtoolize is not the way to move forward. elibtoolize is designed to do exactly one thing, and this is not part of that goal. bug Diego about the autopatching stuff. (In reply to comment #16) > i'm not asking anything. i'm saying that overloading elibtoolize is not the > way to move forward. elibtoolize is designed to do exactly one thing, and this > is not part of that goal. > > bug Diego about the autopatching stuff. > Cool, but it's not overloading, the 1.5* patches are already there. These ones are just a better fix for what they tried to fix in the first place. (another alternative could be: cd "${S}/<location of install-sh>" epatch "${PORTDIR}/eclass/ELT-patches/install-sh/1.5.4" If elibtoolize is too much.) Autoepatch will still have a long time to come. Considering that the set for install-sh is already there (I didn't add it by the way, Roy did), I'd say go on and update it. As for autoepatch, I'll see if I can find someone to help me. These are in cvs now. |