Bug 188760 - kde-base/klaptopdaemon-3.5.7-r1: "Hibernate" menu item missing with 2.6.22 kernels (ebuild containing fix included)
Bug#: 188760 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: minor Priority: P2
Resolution: REMIND Assigned To: kde@gentoo.org Reported By: temerkhanov@mail.ru
Component: Ebuilds
URL: 
Summary: kde-base/klaptopdaemon-3.5.7-r1: "Hibernate" menu item missing with 2.6.22 kernels (ebuild containing fix included)
Keywords:  
Status Whiteboard: 
Opened: 2007-08-13 23:01 0000
Description:   Opened: 2007-08-13 23:01 0000 
There is a problem with klaptopdaemon and 2.6.22 (and probably higher) Linux
kernels. There are no "Hibernate" and "Lock&Hibernate" menu items even if those
are enabled at "ACPI Config" page and helper application is set up correctly.
This is due to /sys/power/state file format have changed (\n appended) and
has_acpi_sleep() function is unable to handle it properly.

I've changed this function so that it can handle both old and new format as
well (tested with gentoo-sources-2.6.22-r2 and 2.6.21-r4). I've also removed
/proc/acpi/sleep checks due to deprecation of it in mainline kernels and
scheduled ACPI procfs interface removal.

Reproducible: Always

Steps to Reproduce:
1. emerge >=gentoo-sources-2.6.22-r2
2. Start KDE, go to klaptopdaemon's menu
3. Select "Configure KLaptop...", go to "ACPI Config" page, check "Enable
hibernate"
4. Go to klaptopdaemon's menu again

Actual Results:  
Both "Hibernate" and "Lock&Hibernate" menu items are missing

Expected Results:  
Both "Hibernate" and "Lock&Hibernate" menu items present

------- Comment #1 From Sergey Temerkhanov 2007-08-13 23:02:27 0000 ------- 
Created an attachment (id=127998) [details]
klaptopdaemon-3.5.7-has_acpi_sleep.patch

------- Comment #2 From Sergey Temerkhanov 2007-08-13 23:03:00 0000 ------- 
Created an attachment (id=127999) [details]
klaptopdaemon-3.5.7-r1.ebuild

------- Comment #3 From Wulf Krueger (RETIRED) 2007-08-17 08:58:21 0000 ------- 
First of all, please file an upstream bug for this and post its URL here. This
is really something that should go into KDE itself. 

That said, I need this, too, and so I have successfully tested your patch and
added it for now to both kdeutils and klaptopdaemon. Especially since quite a
few upstream bugs for other enhancements have been open at bugs.kde.org for
ages and the sources in the focus areas haven't been changed for a long time.

------- Comment #4 From Sergey Temerkhanov 2007-08-17 11:22:19 0000 ------- 
Here's the URL for this bug in upstream:
http://bugs.kde.org/show_bug.cgi?id=148928