Bug 187882 - media-libs/flac-1.2.0 doesn't compile with USE="-ogg"
Bug#: 187882 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: sound@gentoo.org Reported By: marty.rosenberg@gmail.com
Component: Ebuilds
URL:  http://flac.cvs.sourceforge.net/flac/flac/src/flac/encode.c?r1=1.187&r2=1.188&view=patch
Summary: media-libs/flac-1.2.0 doesn't compile with USE="-ogg"
Keywords:  
Status Whiteboard: 
Opened: 2007-08-06 07:55 0000
Description:   Opened: 2007-08-06 07:55 0000
Not really gentoo specific, unless this is a problem caused by a gentoo patch.
in flac-1.2.0/src/flac/encode.c, on line 2181, 

if(e->use_ogg && e->total_samples_to_encode > 0 && e->total_samp
les_to_encode / e->sample_rate / 10 > 230)

should be

if(
#if FLAC__HAS_OGG
e->use_ogg &&
#endif
 e->total_samples_to_encode > 0 && e->total_samp
les_to_encode / e->sample_rate / 10 > 230)

or something else equivalent.  Personally, I think that the 'changing contents
of if statement based on compile time flags' is disgusting, but whatever.

------- Comment #1 From Samuli Suominen 2007-08-06 10:45:43 0000 -------
(In reply to comment #0)
> Not really gentoo specific, unless this is a problem caused by a gentoo patch.
> in flac-1.2.0/src/flac/encode.c, on line 2181, 

It's not because of our patches but definately a problem, thanks.. looking at
it.

------- Comment #2 From Samuli Suominen 2007-08-06 11:12:46 0000 -------
Applied upstream patch fixing this. Thanks again for reporting :)