Bug 186750 - mozilla-firefox/xulrunner ebuilds sed substitution of wrong file
Bug#: 186750 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: minor Priority: P2
Resolution: FIXED Assigned To: mozilla@gentoo.org Reported By: wuno@lsvw.de
Component: Ebuilds
URL: 
Summary: mozilla-firefox/xulrunner ebuilds sed substitution of wrong file
Keywords:  
Status Whiteboard: 
Opened: 2007-07-27 06:37 0000
Description:   Opened: 2007-07-27 06:37 0000 
type about:buildconfig in mozilla-firefox or epiphany built on xulrunner,
you'll see
-Wno-non-virtual-dtor -Wno-long-long -march=athlon64 -pipe -fPIC
-Wno-return-type -w -fshort-wchar -pthread -pipe -DARON_WAS_HERE  <---
same in seamonkey
Wno-non-virtual-dtor -Wno-long-long -march=athlon64 -pipe -fPIC
-Wno-return-type -w -fshort-wchar -pthread -pipe
-DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\"
-DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib64/nsbrowser/plugins\"  <---

The reason is that we substitute the seamonkey builconfig.html residing in xpfe
also in mozilla-firefox and xulrunner ebuilds.
However, there is a second buildconfig.html in toolkit/content that is the
correct one for toolkit applications like mozilla-firefox and xulrunner
patch for the ebuild to follow

Reproducible: Always

------- Comment #1 From Walter Meinl 2007-07-27 06:38:23 0000 ------- 
Created an attachment (id=126107) [details]
mozilla-firefox-2.0.0.5.ebuild patch

------- Comment #2 From Walter Meinl 2007-07-27 06:39:00 0000 ------- 
Created an attachment (id=126108) [details]
xulrunner-1.8.1.5 patch

------- Comment #3 From Jakub Moc (RETIRED) 2007-07-27 06:47:48 0000 ------- 
Hmmm? What's exactly wrong with that?

------- Comment #4 From Walter Meinl 2007-07-27 15:40:58 0000 ------- 
(In reply to comment #3)
> Hmmm? What's exactly wrong with that?
> 
For some problems with econf the define
-DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\" cannot be used during
configuring, therefor the placeholder -DARON_WAS_HERE is used, that becomes
substituted by sed during compile time. In case of mozilla-firefox and
xulrunner we have to do the substition in buildconfig.html in the
toolkit/content directory and not in the xpfe/global directory. The latter is
for seamonkey. When we do the substitution in the correct file, we see also in
mozilla-firefox or xulrunner embedded browsers in about:buildconfig
-DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\"
-DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib64/nsbrowser/plugins\" and not
-DARON_WAS_HERE
Of course, this is only cosmetics, therefore of only minor severity but its
easy to fix.

------- Comment #5 From Walter Meinl 2007-09-20 06:50:48 0000 ------- 
changing Summary to be more precise

------- Comment #6 From Raúl Porcel 2007-10-21 20:53:10 0000 ------- 
Fixed on firefox, seamonkey, and xulrunner, i'll leave this bug open so i don't
forget about thunderbird

Thanks

------- Comment #7 From Walter Meinl 2007-10-21 21:13:30 0000 ------- 
(In reply to comment #6)
> Fixed on firefox, seamonkey, and xulrunner, i'll leave this bug open so i don't
> forget about thunderbird
> 
> Thanks
> 

Thanks for fixing this, however I didn't post a patch for Seamonkey as in this
particular case 
${S}/xpfe/global/buildconfig.html
was correct.
For thunderbird we won't need a fix as we don't support plugins.

------- Comment #8 From Lars Wendler (Polynomial-C) 2007-10-22 07:26:43 0000 ------- 
Yes, this change should be reverted in seamonkey ebuilds until seamonkey-2.0 is
out which will use toolkit as well...

------- Comment #9 From Raúl Porcel 2007-10-22 09:38:45 0000 ------- 
Okay, all done then.

Thanks

------- Comment #10 From Walter Meinl 2007-10-22 14:22:36 0000 ------- 
(In reply to comment #9)
> Okay, all done then.
> 
> Thanks
> 

Sorry to bother again, the correct substitution for firefox and xulrunner is
/toolkit/content/ not /toolkit/global/ as it's now in the new ebuilds.

------- Comment #11 From Raúl Porcel 2007-10-22 14:35:50 0000 ------- 
Fixed again, thanks, sorry for making mistakes, my head fails a bit :)