Summary: | media-libs/libart_lgpl-2.3.19-r1 tried to run a cross built binary during package build | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Eddy Petrișor <eddy.petrisor> |
Component: | New packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | eddy.petrisor |
Priority: | High | ||
Version: | 2007.0 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch for upstream cross building problem (non-bootstrapped source)
patch for the bootstrapped source |
Description
Eddy Petrișor
2007-07-17 18:22:00 UTC
Do you have libart_lgpl installed on the host system? It's entirely possible that it cannot be cross compiled sanely, but we'll start with the above. I looked in the make file; it tries to compile a small code that allows detection of the types on the target. Of course, the compilation of that file succedes, but that binary can't be ran. libart_lgpl should instead use inttypes.h to detect those types. You should probably open a bug upstream, then, and post the URL here, so we can track it? RESOLVED FIXED doesn't seem to be the correct resolution for this... I agree this bug can stay open until the real fix is available. It's not like we are greedy on closing bug rank :) Created attachment 128318 [details, diff] patch for upstream cross building problem (non-bootstrapped source) This is the patch that should end up in upstream since it touches only the .am file from which the Makefile.in file is generated. Of course, it could be cleaner and the art_config.h file could be avoided entirely, but it seems that google returns results when looking for 'include art_config.h'; Thus the patch. I submitted it upstream: http://bugzilla.gnome.org/show_bug.cgi?id=467416 Created attachment 128320 [details, diff]
patch for the bootstrapped source
Same as before, but it extends the changes over Makefile.in, too (which is a by product of Makefile.am) to allow correct cross building on gentoo
Comment on attachment 128320 [details, diff]
patch for the bootstrapped source
I cross compile succesfully the package with this patch applied
I've committed an alternative. Can you try it out? It should have the same effect as your patch. (In reply to comment #8) > I've committed an alternative. Can you try it out? It should have the same > effect as your patch. > It can't have the same effect as long as you did not define art_u* based on stdint.h definitions. The removed definitions are a side benefit of the patch, but not the main target of the patch. <sigh> I can't believe I missed that. I must have been fooled by the endings on the types. I committed another try. Can you look? (In reply to comment #10) > <sigh> I can't believe I missed that. I must have been fooled by the endings > on the types. > > I committed another try. Can you look? That is basically a clean up version of the initial patch I sent. It should be ok (the package xmerged). I haven't thoroughly checked the Makefile, but I guess xmerge would have barfed if something was wrong :-) . It's slightly different; I got rid of the generation entirely, rather than copying over like you did. Thanks for testing. |