Bug 185618 - net-wireless/rt2570-20070209 compile fails w/ 2.6.22 kernels
Bug#: 185618 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: WONTFIX Assigned To: steev@gentoo.org Reported By: marktrolley@gmail.com
Component: Ebuilds
URL: 
Summary: net-wireless/rt2570-20070209 compile fails w/ 2.6.22 kernels
Keywords:  
Status Whiteboard: 
Opened: 2007-07-17 00:49 0000
Description:   Opened: 2007-07-17 00:49 0000
The rt2570 wireless card driver (rt2570-20070209) fails to build against kernel
2.6.22.

Reproducible: Always

Steps to Reproduce:
emerge rt2570-20070209 when running kernel 2.6.22.

Actual Results:  
>>> Emerging (1 of 1) net-wireless/rt2570-20070209 to /
 * rt2570-20070209.tar.bz2 RMD160 ;-) ...                                 [ ok
]
 * rt2570-20070209.tar.bz2 SHA1 ;-) ...                                   [ ok
]
 * rt2570-20070209.tar.bz2 SHA256 ;-) ...                                 [ ok
]
 * rt2570-20070209.tar.bz2 size ;-) ...                                   [ ok
]
 * checking ebuild checksums ;-) ...                                      [ ok
]
 * checking auxfile checksums ;-) ...                                     [ ok
]
 * checking miscfile checksums ;-) ...                                    [ ok
]
 * checking rt2570-20070209.tar.bz2 ;-) ...                               [ ok
]
>>> cfg-update-1.8.2-r1: Checksum index is up-to-date ...
 * Determining the location of the kernel source code
 * Found kernel source directory:
 *     /usr/src/linux
 * Found kernel object directory:
 *     /lib/modules/2.6.22-gentoo-r1/build
 * Found sources for kernel version:
 *     2.6.22-gentoo-r1
 * Checking for suitable kernel configuration options...
 *   CONFIG_NET_RADIO:   is not set when it should be.
 * Please check to make sure these options are set correctly.
 * Failure to do so may cause unexpected problems.
 * Once you have satisfied these options, please try merging
 * this package again.

!!! ERROR: net-wireless/rt2570-20070209 failed.
Call stack:
  ebuild.sh, line 1637:   Called dyn_setup
  ebuild.sh, line 704:   Called qa_call 'pkg_setup'
  ebuild.sh, line 44:   Called pkg_setup
  rt2570-20070209.ebuild, line 19:   Called linux-mod_pkg_setup
  linux-mod.eclass, line 464:   Called linux-info_pkg_setup
  linux-info.eclass, line 572:   Called check_extra_config
  linux-info.eclass, line 471:   Called die

!!! Incorrect kernel configuration options
!!! If you need support, post the topmost build error, and the call stack if
relevant.
!!! A complete build log is located at
'/var/tmp/portage/net-wireless/rt2570-20070209/temp/build.log'.

Expected Results:  
Module to compile.

------- Comment #1 From Mark Trolley 2007-07-17 00:50:31 0000 -------
emerge --info:

Portage 2.1.2.9 (default-linux/amd64/2007.0, gcc-4.1.2, glibc-2.5-r4,
2.6.22-gentoo-r1 x86_64)
=================================================================
System uname: 2.6.22-gentoo-r1 x86_64 AMD Athlon(tm) 64 Processor 3200+
Gentoo Base System release 1.12.9
Timestamp of tree: Mon, 16 Jul 2007 21:20:01 +0000
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.4.4-r4
dev-python/pycrypto: 2.0.1-r5
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.23b
virtual/os-headers:  2.6.22-r1
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/
/etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/splash /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="ftp://gentoo.arcticnetwork.ca/pub/gentoo/
http://gentoo.arcticnetwork.ca/ ftp://mirrors.tera-byte.com/pub/gentoo
http://gentoo.mirrors.tera-byte.com/
ftp://distro.ibiblio.org/pub/linux/distributions/gentoo/
http://distro.ibiblio.org/pub/linux/distributions/gentoo/ "
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude=/distfiles --exclude=/local --exclude=/packages
--filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X aac acl alsa amd64 animgif apache2 artworkextra berkdb
binary-drivers bitmap-fonts bittorrent bzip2 cdr clamav cli colordiff cracklib
crypt cups dbus divx dri dvd dvdr dvdread encode faillog firefox fortran gdbm
gif gimp gmedia gnome gpm gre gs gtk hardened iconv imagemagick imap ipv6
javascript john jpeg junit keyring keyscrub lame libclamav libg++ logrotate lzw
midi mmx mmxext mp3 mpeg mpeg2 mplayer mplayer-bin msn mudflap musicbrainz
mysql nautilus ncurses net nls nptl nptlonly nsplugin ntfs offensive opengl
openmp openssl pam pcap pcre pdf perl php png pppd python quicktime rar
rdesktop readline realmedia reflection samba scrobbler session sftp signatures
spell spl spoof-source sse sse2 ssl subversion symlink syslog tagwriting tcpd
thunderbird tiff transcode truetype truetype-fonts type1 type1-fonts unicode
vim-syntax vnc vncviewer vorbis wav webdav wifi wireshark wma wmp xinerama
xinetd xorg xvid zip zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem
bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel
intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci"
ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file
hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route
share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux"
LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses
text" USERLAND="GNU" VIDEO_CARDS="fglrx"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS,
LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

------- Comment #2 From Mark Trolley 2007-07-17 13:19:15 0000 -------
Removing the CONFIG_CHECK is only part of the issue. rt2570-20070209 doesn't
build against kernel 2.6.22, but I created an ebuild for one of yesterday's
hourly tarballs and it built and works fine.

------- Comment #3 From Daniel Drake 2007-07-22 18:01:17 0000 -------
The check can be fixed something like this:

pkg_setup() {
        if kernel_is ge 2 6 22; then
                CONFIG_CHECK="WIRELESS_EXT ${CONFIG_CHECK}"
        else
                CONFIG_CHECK="NET_RADIO ${CONFIG_CHECK}"
        fi
        linux-mod_pkg_setup

As for the actual compile errors, please post them here and I will comment on
how to fix them. While adding a new snapshot to the tree would also work, we
need to get this fixed in the stable tree sooner than that, so patching would
probably be the best approach.

------- Comment #4 From Daniel Drake 2007-07-28 16:53:57 0000 -------
I'll be starting the 2.6.22 stable push in the next few days, would be nice to
see this fixed.

------- Comment #5 From Steffen 'j0inty' Stollfuß 2007-08-02 13:51:33 0000 -------
(In reply to comment #4)
> I'll be starting the 2.6.22 stable push in the next few days, would be nice to
> see this fixed.
> 

Hi,

I needed the driver for a Spharion Turbolink USB Adapter with an rt2570 chip. I
use the current gentoo-sources 2.6.22-r2 but the version 20070209 didn't
compiled at me. So I use the lastest cvs snapshot 2007080203 and everything
compiled fine with your ebuild fix.

regards
J0!nty.sL

------- Comment #6 From MickKi 2007-08-15 21:03:42 0000 -------
Daniel, how long before this makes it to the tree please?

With ndiswrapper *and* this driver checking for CONFIG_NET_RADIO there's no
option for having wireless with the 2.6.22 kernel.
-- 
Regards,
Mick 

------- Comment #7 From Steev Klimaszewski 2007-08-16 02:05:15 0000 -------
The config check isn't the only issue - and this is an *unstable* driver - so
while its nice for it to work with a stable driver, sadly, that isn't the case.
 I had been working on a version that worked with 2.6.22 but when I was going
over my final checks before checking it into portage, when I attempted to
digest it, it was no longer available from upstream (the version I was using) 
I am working on getting a new version into the tree however.

------- Comment #8 From Stefan Schweizer 2007-08-29 19:00:05 0000 -------
config check thing fixed

------- Comment #9 From Thomas Dixon 2007-09-03 05:38:11 0000 -------
I receive the following when trying to merge:

thomas@localhost ~ $ sudo emerge -v rt2570
Password:

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N    ] net-wireless/rt2570-20070209  0 kB 

Total: 1 package (1 new), Size of downloads: 0 kB

>>> Verifying ebuild Manifests...

>>> Emerging (1 of 1) net-wireless/rt2570-20070209 to /
 * rt2570-20070209.tar.bz2 RMD160 ;-) ...                                 [ ok
]
 * rt2570-20070209.tar.bz2 SHA1 ;-) ...                                   [ ok
]
 * rt2570-20070209.tar.bz2 SHA256 ;-) ...                                 [ ok
]
 * rt2570-20070209.tar.bz2 size ;-) ...                                   [ ok
]
 * checking ebuild checksums ;-) ...                                      [ ok
]
 * checking auxfile checksums ;-) ...                                     [ ok
]
 * checking miscfile checksums ;-) ...                                    [ ok
]
 * checking rt2570-20070209.tar.bz2 ;-) ...                               [ ok
]
 * Determining the location of the kernel source code
 * Found kernel source directory:
 *     /usr/src/linux
 * Found kernel object directory:
 *     /lib/modules/2.6.22-gentoo-r5/build
 * Found sources for kernel version:
 *     2.6.22-gentoo-r5
 * Checking for suitable kernel configuration options...                  [ ok
]
>>> Unpacking source...
>>> Unpacking rt2570-20070209.tar.bz2 to /var/tmp/portage/net-wireless/rt2570-20070209/work
>>> Source unpacked.
>>> Compiling source in /var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209 ...
 * Preparing rt2570 module
make: Entering directory `/usr/src/linux-2.6.22-gentoo-r5'
  CC [M] 
/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module/rtusb_main.o
  CC [M] 
/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module/mlme.o
/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module/rtusb_main.c:
In function 'usb_rtusb_probe':
/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module/rtusb_main.c:1907:
error: 'dev_base' undeclared (first use in this function)
/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module/rtusb_main.c:1907:
error: (Each undeclared identifier is reported only once
/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module/rtusb_main.c:1907:
error: for each function it appears in.)
/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module/rtusb_main.c:1907:
error: 'struct net_device' has no member named 'next'
make[1]: ***
[/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module/rtusb_main.o]
Error 1
make[1]: *** Waiting for unfinished jobs....
make: ***
[_module_/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module]
Error 2
make: Leaving directory `/usr/src/linux-2.6.22-gentoo-r5'

!!! ERROR: net-wireless/rt2570-20070209 failed.
Call stack:
  ebuild.sh, line 1638:   Called dyn_compile
  ebuild.sh, line 985:   Called qa_call 'src_compile'
  ebuild.sh, line 44:   Called src_compile
  ebuild.sh, line 1328:   Called linux-mod_src_compile
  linux-mod.eclass, line 516:   Called die

!!! Unable to make  -C /usr/src/linux
M=/var/tmp/portage/net-wireless/rt2570-20070209/work/rt2570-20070209/Module
modules.
!!! If you need support, post the topmost build error, and the call stack if
relevant.
!!! A complete build log is located at
'/var/tmp/portage/net-wireless/rt2570-20070209/temp/build.log'.

thomas@localhost ~ $ 

------- Comment #10 From MickKi 2007-10-16 21:44:47 0000 -------
Same here with gentoo-sources-2.6.22-r8.  (Unfortunately, the
rt2570-1.1.0_beta2 also fails with a similar error.  If you think it's relevant
to this bug contact me off line for a copy of the emerge log).
-- 
Regards,
Mick

------- Comment #11 From Steev Klimaszewski 2008-01-23 03:31:39 0000 -------
Unfortunately, upstream isn't too concerned with the rt2570 driver any longer,
this should probably be tree-cleaned, or something.  They are focusing on the
rt2x00 driver being in the kernel itself...

------- Comment #12 From Jeremy Olexa (darkside) 2009-09-04 02:13:18 0000 -------
removed from tree, wontfix