Bug 184716 - alsa-utils-1.0.14.ebuild still has an ugly "XXX write TLV"
Bug#: 184716 Product:  Gentoo Linux Version: unspecified Platform: x86
OS/Version: Linux Status: RESOLVED Severity: minor Priority: P2
Resolution: FIXED Assigned To: alsa-bugs@gentoo.org Reported By: grafgrimm77@gmx.de
Component: Ebuilds
URL: 
Summary: alsa-utils-1.0.14.ebuild still has an ugly "XXX write TLV"
Keywords:  
Status Whiteboard: 
Opened: 2007-07-09 11:03 0000
Description:   Opened: 2007-07-09 11:03 0000 
alsa-utils-1.0.14/alsactl/state.c has the bad looking line:
fprintf(stderr, "XXX write TLV...\n");

this is printed out while booting init phase

Reproducible: Always

Steps to Reproduce:
1. rc-update add alsasound boot
2. reboot
3. look at the boot messages

Actual Results:  
XXX write TLV

Expected Results:  
no such a message

------- Comment #1 From Mario Bachmann 2007-07-09 11:04:24 0000 ------- 
Created an attachment (id=124316) [details]
corrected ebuild

------- Comment #2 From Mario Bachmann 2007-07-09 11:05:26 0000 ------- 
Created an attachment (id=124317) [details]
new patch alsa-utils-1.0.14-xxx-write-tlv.patch

------- Comment #3 From Mario Bachmann 2007-07-09 11:07:35 0000 ------- 
i created a patch and tested it successfully. here it works now. the ugly
message is gone while booting.

------- Comment #4 From Petteri Räty 2007-07-09 11:08:19 0000 ------- 
(In reply to comment #2)
> Created an attachment (id=124317) [edit] [details]
> new patch alsa-utils-1.0.14-xxx-write-tlv.patch
> 

Silencing errors from code is probably not something that upstream would accept
but you can try. Any way please submit your issue upstream too.

------- Comment #5 From Mario Bachmann 2007-07-09 11:20:17 0000 ------- 
> Silencing errors from code is probably not something that upstream would accept
> but you can try. Any way please submit your issue upstream too.

i do not understand. how to submit this issue upstream? 
beside: i accepted the patch and i think this is not only my issue. ;-)

------- Comment #6 From Jakub Moc (RETIRED) 2007-07-09 18:52:11 0000 ------- 
(In reply to comment #5)
> i do not understand. how to submit this issue upstream? 

https://bugtrack.alsa-project.org/alsa-bug/

------- Comment #7 From Christian Heim (RETIRED) 2007-08-11 14:28:52 0000 ------- 
I'm not going to incorporate this change unless UPSTREAM agrees on that. Sorry.

------- Comment #8 From Mario Bachmann 2007-08-11 15:01:38 0000 ------- 
is it really such hard to take responsibility for deleting the ugly message
"XXX write TLV" caused by an obviously debugging relict in the file state.c of
alsa-utils? unbelievable!

------- Comment #9 From Arfrever Frehtes Taifersar Arahesis 2007-09-16 16:05:50 0000 ------- 
(In reply to comment #7)
> I'm not going to incorporate this change unless UPSTREAM agrees on that.

Upstream agreed.
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3185
http://hg-mirror.alsa-project.org/alsa-utils/rev/b230fef1ea76

Please reopen this bug.

------- Comment #10 From Petteri Räty 2007-09-16 20:41:06 0000 ------- 
(In reply to comment #8)
> is it really such hard to take responsibility for deleting the ugly message
> "XXX write TLV" caused by an obviously debugging relict in the file state.c of
> alsa-utils? unbelievable! 
> 

Keeping patches in sync with upstream changes requires work which can be
avoided when the changes are merged upstream.

(In reply to comment #9)
> 
> Please reopen this bug.
> 

done

------- Comment #11 From Christian Heim (RETIRED) 2007-09-17 16:47:13 0000 ------- 
(In reply to comment #9)
> (In reply to comment #7)
> > I'm not going to incorporate this change unless UPSTREAM agrees on that.
> 
> Upstream agreed.
> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3185
> http://hg-mirror.alsa-project.org/alsa-utils/rev/b230fef1ea76
> 
> Please reopen this bug.

And it's in CVS now. Thanks to whoever took that upstream.