Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 184261

Summary: Better emacs support for app-text/txt2tags
Product: Gentoo Linux Reporter: Christian Faulhammer (RETIRED) <fauli>
Component: New packagesAssignee: Gentoo SGML project <sgml>
Status: RESOLVED FIXED    
Severity: enhancement CC: emacs
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 184166    
Attachments: For the ebuild
New site init file: 51txt2tags-gentoo.el
Updated patch for txt2tags-2.3.ebuild

Description Christian Faulhammer (RETIRED) gentoo-dev 2007-07-05 06:24:55 UTC
Emacs support could be better and some minor tweaks.  Patches to follow
Comment 1 Christian Faulhammer (RETIRED) gentoo-dev 2007-07-05 06:37:15 UTC
Created attachment 123913 [details, diff]
For the ebuild
Comment 2 Christian Faulhammer (RETIRED) gentoo-dev 2007-07-05 06:38:30 UTC
Created attachment 123915 [details]
New site init file: 51txt2tags-gentoo.el
Comment 3 Ulrich Müller gentoo-dev 2007-07-05 06:52:41 UTC
(In reply to comment #1)
> +		elisp-install ${PN} extras/txt2tags-mode.el txt2tags-mode.elc

This is strange, why isn't the .elc in the same directory with the .el?

I think src_compile should either do
    elisp-compile extras/txt2tags-mode.el || die
or
    cd extras; elisp-comp txt2tags-mode.el || die

(The standard elisp-compile is sufficient here since it is only one file.)
Comment 4 Ulrich Müller gentoo-dev 2007-07-14 15:59:08 UTC
Created attachment 124844 [details, diff]
Updated patch for txt2tags-2.3.ebuild

(In reply to comment #3)
> I think src_compile should either do
>     elisp-compile extras/txt2tags-mode.el || die
> [...]

Updated patch taking this change into account.
Comment 5 Leonardo Boshell (RETIRED) gentoo-dev 2007-08-20 10:56:50 UTC
(In reply to comment #4)
> Created an attachment (id=124844) [edit]
> Updated patch for txt2tags-2.3.ebuild
> 
> (In reply to comment #3)
> > I think src_compile should either do
> >     elisp-compile extras/txt2tags-mode.el || die
> > [...]
> 
> Updated patch taking this change into account.

Looks good. Feel free to commit your patch, bumping the revision number.

Thanks.
Comment 6 Ulrich Müller gentoo-dev 2007-08-20 15:58:55 UTC
Committed as -r1.

ppc-macos: Adding you to CC since repoman gave me some "badindev" warnings. You may reconsider your keyword.
Comment 7 Fabian Groffen gentoo-dev 2007-08-20 16:13:36 UTC
ppc-macos moved to prefix.
Comment 8 Ulrich Müller gentoo-dev 2007-08-20 16:17:44 UTC
Fixed then.