Bug 181288 - media-sound/lastfmplayer-1.1.3-r2 - endian problem causes wrong playback on big endian based systems
Bug#: 181288 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: ppc@gentoo.org Reported By: ich@az2000.de
Component: Applications
URL: 
Summary: media-sound/lastfmplayer-1.1.3-r2 - endian problem causes wrong playback on big endian based systems
Keywords:  
Status Whiteboard: 
Opened: 2007-06-08 10:23 0000
Description:   Opened: 2007-06-08 10:23 0000 
Hi

I already have made a patch for this issue :)

Will attach it...

Except for this problem (which I fixed now), lastfmplayer works stable here, so
please add ~ppc (and perhaps other other big endian systems; but I only tested
PPC).

------- Comment #1 From Albert Zeyer 2007-06-08 10:24:19 0000 ------- 
Created an attachment (id=121486) [details]
lastfm_mp3transcode.diff

------- Comment #2 From Joe Jezak 2007-06-28 14:23:39 0000 ------- 
Thanks for the patch!  I've updated it for the new version too.  Please make
sure to submit this for inclusion upstream!

Thanks!

------- Comment #3 From Albert Zeyer 2007-07-03 14:09:36 0000 ------- 
I just tested the new version 1.3.0.58 and it seems that the patch is not
needed there. That means, with applied patch, you again have the bytes switched
one time too often and you again got the wrong playblack. It seems that they
have switched the bytes elsewhere in 1.3.0.58 (I haven't took a more deeper
look at the code to determit where in detail).

I have tested 1.3.0.58 without the patch and it works good. So the simple
solution: Use the patch for 1.1.3 but remove it for 1.3.0.58.

------- Comment #4 From Joe Jezak 2007-07-04 00:59:03 0000 ------- 
Whoops. :p  I only tested it on 1.1.3-r2, I've removed the newer one, thanks.