Bug 179732

Summary:	jack-audio-connection-kit uses deprecated check-kernel eclass
Product:	Gentoo Linux	Reporter:	Martin Väth <martin>
Component:	New packages	Assignee:	Marius Mauch (RETIRED) <genone>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jakub, sound
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to use kmod instead of check-kernel jack-audio-connection-kit-0.102.20.ebuild.diff

Description Martin Väth 2007-05-25 10:30:28 UTC

jack-audio-connection-kit seems to be the only package in the tree whose most current ebuild still uses the deprecated check-kernel eclass.
In particular, this means that the package won't compile for people using the kbuild output feature of the kernel, see e.g. bug 51903.

This can be fixed by using the kmod eclass instead of the check-kernel eclass.
I attach a patch for 0.102.20 which works for me.

Comment 1 Martin Väth 2007-05-25 10:31:35 UTC

Created attachment 120261 [details, diff]
Patch to use kmod instead of check-kernel

Comment 2 Jakub Moc (RETIRED) gentoo-dev

2007-05-25 10:38:09 UTC

Comment on attachment 120261 [details, diff]
Patch to use kmod instead of check-kernel

kmod.eclass

<snip>
# !!!!!!!!!!
#
# BEWARE: DO NOT USE. THIS ECLASS IS DEPRECATED AND BROKEN. DO NOT USE.
</snip>

Comment 3 Jakub Moc (RETIRED) gentoo-dev

2007-05-25 10:42:25 UTC

http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-sound/jack-audio-connection-kit/jack-audio-connection-kit-0.102.20.ebuild?r1=1.4&r2=1.5

Comment 4 Jakub Moc (RETIRED) gentoo-dev

2007-05-25 10:48:39 UTC

Created attachment 120264 [details, diff]
jack-audio-connection-kit-0.102.20.ebuild.diff

Comment 5 Martin Väth 2007-05-25 12:00:04 UTC

Thanks for the two corrections. Also the new (corrected) patch compiled fine here on x86 and on amd64 (both with 2.6 kernels and using KERNEL_DIR and KBUILD_OUTPUT environments).

OT: Maybe it would be a good idea to include a warning as in comment #2 also in check-kernel.eclass

Comment 6 Marius Mauch (RETIRED) gentoo-dev

2007-06-23 16:06:59 UTC

No clue why this was assigned to me ...

Comment 7 Jakub Moc (RETIRED) gentoo-dev

2007-06-23 16:12:02 UTC

(In reply to comment #6)
> No clue why this was assigned to me ...

http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-sound/jack-audio-connection-kit/jack-audio-connection-kit-0.102.20.ebuild?r1=1.4&r2=1.5

Comment 8 Diego Elio Pettenò (RETIRED) gentoo-dev

2007-06-29 12:36:48 UTC

I've committed the patch now, so let's consider this closed.