Bug 179732 - jack-audio-connection-kit uses deprecated check-kernel eclass
Bug#: 179732 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: genone@gentoo.org Reported By: vaeth@mathematik.uni-wuerzburg.de
Component: Ebuilds
URL: 
Summary: jack-audio-connection-kit uses deprecated check-kernel eclass
Keywords:  
Status Whiteboard: 
Opened: 2007-05-25 10:30 0000
Description:   Opened: 2007-05-25 10:30 0000 
jack-audio-connection-kit seems to be the only package in the tree whose most
current ebuild still uses the deprecated check-kernel eclass.
In particular, this means that the package won't compile for people using the
kbuild output feature of the kernel, see e.g. bug 51903.

This can be fixed by using the kmod eclass instead of the check-kernel eclass.
I attach a patch for 0.102.20 which works for me.

------- Comment #1 From Martin Väth 2007-05-25 10:31:35 0000 ------- 
Created an attachment (id=120261) [details]
Patch to use kmod instead of check-kernel

------- Comment #2 From Jakub Moc (RETIRED) 2007-05-25 10:38:09 0000 ------- 
(From update of attachment 120261 [details])
kmod.eclass

<snip>
# !!!!!!!!!!
#
# BEWARE: DO NOT USE. THIS ECLASS IS DEPRECATED AND BROKEN. DO NOT USE.
</snip>

------- Comment #3 From Jakub Moc (RETIRED) 2007-05-25 10:42:25 0000 ------- 
http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-sound/jack-audio-connection-kit/jack-audio-connection-kit-0.102.20.ebuild?r1=1.4&r2=1.5

------- Comment #4 From Jakub Moc (RETIRED) 2007-05-25 10:48:39 0000 ------- 
Created an attachment (id=120264) [details]
jack-audio-connection-kit-0.102.20.ebuild.diff

------- Comment #5 From Martin Väth 2007-05-25 12:00:04 0000 ------- 
Thanks for the two corrections. Also the new (corrected) patch compiled fine
here on x86 and on amd64 (both with 2.6 kernels and using KERNEL_DIR and
KBUILD_OUTPUT environments).

OT: Maybe it would be a good idea to include a warning as in comment #2 also in
check-kernel.eclass

------- Comment #6 From Marius Mauch (RETIRED) 2007-06-23 16:06:59 0000 ------- 
No clue why this was assigned to me ...

------- Comment #7 From Jakub Moc (RETIRED) 2007-06-23 16:12:02 0000 ------- 
(In reply to comment #6)
> No clue why this was assigned to me ...

http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-sound/jack-audio-connection-kit/jack-audio-connection-kit-0.102.20.ebuild?r1=1.4&r2=1.5

------- Comment #8 From Diego E. 'Flameeyes' Pettenò 2007-06-29 12:36:48 0000 ------- 
I've committed the patch now, so let's consider this closed.