Bug 179225 - net-wireless/bluez-gnome-0.7 version bump
Bug#: 179225 Product:  Gentoo Linux Version: 2007.0 Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: betelgeuse@gentoo.org Reported By: dick@mrns.nl
Component: Ebuilds
URL: 
Summary: net-wireless/bluez-gnome-0.7 version bump
Keywords:  EBUILD
Status Whiteboard: 
Opened: 2007-05-20 13:55 0000
Description:   Opened: 2007-05-20 13:55 0000 
new ebuild net-wireless/bluez-gnome-0.7

------- Comment #1 From Dick Marinus 2007-05-20 13:56:19 0000 ------- 
Created an attachment (id=119794) [details]
net-wireless/bluez-gnome-0.7.ebuild

------- Comment #2 From Dick Marinus 2007-05-20 14:18:26 0000 ------- 
Marcel has improved my patch and --disable-schemas-install is working :-)

It seems to work better with the input service for me.

------- Comment #3 From Petteri Räty 2007-05-20 16:00:01 0000 ------- 
Committed with the following modifications:
betelgeuse@pena /usr/portage/net-wireless/bluez-gnome $ diff -u
attachment.cgi\?id\=119794 bluez-gnome-0.7.ebuild
--- attachment.cgi?id=119794    2007-05-20 18:58:24.000000000 +0300
+++ bluez-gnome-0.7.ebuild      2007-05-20 18:58:09.000000000 +0300
@@ -17,16 +17,13 @@
        >=x11-libs/libnotify-0.3.2
        >=gnome-base/gconf-2.6
        >=dev-libs/dbus-glib-0.60
+       sys-apps/hal
+       x11-proto/xproto
        >=x11-libs/gtk+-2.6"
 RDEPEND="=net-wireless/bluez-utils-3*
        ${DEPEND}"

-src_compile() {
-       econf --disable-schemas-install || die "econf failed"
-       emake || die "emake failed"
-}
-src_install() {
-       emake DESTDIR="${D}" install || die "make install failed"
-       dodoc AUTHORS README NEWS
-}
+G2CONF="--disable-schemas-install"
+
+DOCS="dodoc AUTHORS README NEWS ChangeLog"

------- Comment #4 From Dick Marinus 2007-05-20 19:06:09 0000 ------- 
I think G2CONF="--disable-schemas-install" should be removed, this is handled
by the gnome2 eclass.

from gnome2.eclass:

        # we must delay gconf schema installation due to sandbox
        export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL="1"

------- Comment #5 From Petteri Räty 2007-05-20 19:19:37 0000 ------- 
(In reply to comment #4)
> I think G2CONF="--disable-schemas-install" should be removed, this is handled
> by the gnome2 eclass.
> 

s/should be removed/is redundant/

Committed.

------- Comment #6 From Dick Marinus 2007-05-20 19:29:43 0000 ------- 
Great! It's not redundant, the eclass is calling make install with
GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1 in src_install and with unset
GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL in pkg_postinst.

With disable-schemas-install no schemas are installed.

------- Comment #7 From Petteri Räty 2007-05-20 19:40:06 0000 ------- 
(In reply to comment #6)
> Great! It's not redundant, the eclass is calling make install with
> GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1 in src_install and with unset
> GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL in pkg_postinst.
> 
> With disable-schemas-install no schemas are installed.
> 

No? It installs them manually using eclass functions.