Bug 178430 - net-misc/vnc-4.1.2-r3 ~x86-fbsd ebuild & keyword request
Bug#: 178430 Product:  Gentoo/Alt Version: unspecified Platform: All
OS/Version: FreeBSD Status: NEW Severity: enhancement Priority: P2
Resolution:  Assigned To: armin76@gentoo.org Reported By: lavajoe@gentoo.org
Component: FreeBSD
URL: 
Summary: net-misc/vnc-4.1.2-r3 ~x86-fbsd ebuild & keyword request
Keywords:  
Status Whiteboard: 
Opened: 2007-05-13 20:50 0000
Description:   Opened: 2007-05-13 20:50 0000 
1) Changed "cp -a" to "cp -RPp" for bsd compat (needed for "server" USE flag)
2) Tested both vncviewer and vncserver

Requesting keyword ~x86-fbsd with this new ebuild (to be attached).


Reproducible: Always

------- Comment #1 From Joe Peterson 2007-05-13 20:51:01 0000 ------- 
Created an attachment (id=119148) [details]
vnc-4.1.2-r3.ebuild  (this is a diff)

------- Comment #2 From Joe Peterson 2007-05-14 04:26:51 0000 ------- 
Created an attachment (id=119171) [details]
files/vnc-4.1.2-freebsd.patch

Patch to create xauth cookie on FreeBDS without the need for "mcookie" (only
available in Linux).

------- Comment #3 From Joe Peterson 2007-05-14 04:28:34 0000 ------- 
Created an attachment (id=119173) [details]
vnc-4.1.2-r3.ebuild (diff)

Incorporate patch that allows creation of xauth cookies on FreeBSD

------- Comment #4 From Joe Peterson 2007-06-08 18:30:13 0000 ------- 
Adding maintainer to CC

------- Comment #5 From Raúl Porcel 2007-06-09 19:06:32 0000 ------- 
Patch and ebuild added, thanks.

Keyword it :)

------- Comment #6 From Joe Peterson 2007-06-09 19:49:41 0000 ------- 
Keyworded (vnc-4.1.2-r3).  Thanks!

------- Comment #7 From SpanKY 2007-06-11 06:39:44 0000 ------- 
wouldnt it be cleaner to try and use `mcookie` and if that fails, fall back to
doing rand ?  that way there would be no direct dependency on FreeBSD

------- Comment #8 From Joe Peterson 2007-06-11 15:45:18 0000 ------- 
Vapier, that sounds like it would work fine and yes, potentially then not be
OS-based.  The only downside I can think of is that by doing this, the Linux
archs would either use mcookie or the other method, depending on if mcookie
were installed.  Maybe this doesn't matter, but there might be a good reason to
have predictable cookie generation on a given arch.  If so, it would probably
be good to have vnc RDEPEND on the package containing mcookie...

------- Comment #9 From SpanKY 2007-06-11 20:17:00 0000 ------- 
which oddly enough is the util-linux package ...

------- Comment #10 From Joe Peterson 2007-06-11 23:01:59 0000 ------- 
Are you suggesting that we leave it as-is but that RDEPEND depend on util-linux
for linux only?  Or do you feel that this should be done at runtime by
detecting a failure with mcookie?

I'm re-assinging to Raúl for now, since he did the patch checkin and may want
to weigh in on this.

------- Comment #11 From SpanKY 2007-06-11 23:16:16 0000 ------- 
the runtime code should see if mcookie works and if it does, use it ...
otherwise it should generate its own

considering the output is simply a md5 hash, there might be a better way than
the current rand() ... maybe grab a few bytes from /dev/random and run md5 on
that

i dont think we need a direct depend on util-linux in RDEPEND since that
package is required in the system target for all Linux profiles

------- Comment #12 From Joe Peterson 2008-11-10 14:43:41 0000 ------- 
Raúl,

Just looking back at this bug; I think it is fixed, unless you had input (see
comments 8-11).  In other words, you can probably close this out unless you
want to revisit.

-Thanks, Joe