Bug 177365 - Ebuild for gnome-mastermind-0.3
Bug#: 177365 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: games@gentoo.org Reported By: hey_neken@mundurat.net
Component: Games
URL:  http://www5.autistici.org/gnome-mastermind/
Summary: Ebuild for gnome-mastermind-0.3
Keywords:  EBUILD
Status Whiteboard: 
Opened: 2007-05-06 18:30 0000
Description:   Opened: 2007-05-06 18:30 0000 
Ebuild for gnome-mastermind-0.2, a mastermind like game for GNOME.

Reproducible: Always

Steps to Reproduce:

------- Comment #1 From Mikel Olasagasti 2007-05-06 18:31:20 0000 ------- 
Created an attachment (id=118373) [details]
gnome-mastermind-0.2

------- Comment #2 From Luca Marturana 2007-05-07 13:42:06 0000 ------- 
Ebuild works on x86 too

------- Comment #3 From Filippo Argiolas 2007-06-01 11:22:07 0000 ------- 
New release out there :)
Please update the ebuild!
Check www5.autistici.org/gnome-mastermind for more infos about the new release

------- Comment #4 From Luca Marturana 2007-06-04 11:39:24 0000 ------- 
The attached ebuild works good with version 0.3 too.

------- Comment #5 From Tupone Alfredo 2007-08-25 01:33:49 0000 ------- 
Created an attachment (id=129104) [details]
gnome-mastermind-0.3.ebuild

I'm uploading the ebuild for this game looking for gnome maintainer comments on
that.

------- Comment #6 From Tupone Alfredo 2007-08-25 01:35:08 0000 ------- 
Created an attachment (id=129105) [details]
gnome-mastermind-0.3-gentoo.patch

A patch to remove installation of documentation with make install. I did with
dodoc and selected what to install

------- Comment #7 From Tupone Alfredo 2007-08-25 01:37:04 0000 ------- 
gnome herds: could you please review this?

TIA

------- Comment #8 From Rémi Cardona 2007-08-25 05:48:42 0000 ------- 
Couple things :
- there are no written deps for gtk+, cairo or else
- please use gnome2_src_unpack instead of unpack/cd
- please use DOCS="..." instead of dodoc, this way you can entirely drop
src_install()

That should be a step in the right direction :)

The ebuild doesn't make use of the games eclass, maybe you should take a look
at the gnome-games ebuild to see how to mix both gnome2 and games eclass. Maybe
that's something else to look into.

------- Comment #9 From Tupone Alfredo 2007-08-25 11:52:34 0000 ------- 
A fixed package, following the suggestion on comment #8 has been put in
portage.
Thanks