Bug 174721

Summary:	media-video/mplayer - little cleanup of dvd/dvdread/dvdnav flags
Product:	Gentoo Linux	Reporter:	Yaroslav Isakov <yaroslav.isakov>
Component:	New packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	mplayer-1.0_rc2_pre20070321-r4.ebuild.patch files/mplayer-dvd-verbose.patch mplayer-1.0_rc2_pre20070321-r4.ebuild.patch v2 mplayer-20070427.patch

Description Yaroslav Isakov 2007-04-15 21:52:48 UTC

Hello, I create the patch for media-video/mplayer-1.0_rc2_pre20070321-r4, which cleaned dvd/dvdnav/dvdread use flags and configured mplayer properly. I discovered that dvdread flag is not needed because configure of mplayer check dvdnav first, and if that is failed, it defaults to internal dvdread. Therefore, dvd useflag is also obsolete. Anyway, see the patch.

Comment 1 Yaroslav Isakov 2007-04-15 21:54:06 UTC

Created attachment 116343 [details, diff]
mplayer-1.0_rc2_pre20070321-r4.ebuild.patch

The patch itself

Comment 2 Yaroslav Isakov 2007-04-15 21:58:21 UTC

Also, i create a patch for mplayer configure - please, see
http://svn.mplayerhq.hu/mplayer/trunk/configure?r1=22997&r2=22998

Comment 3 Yaroslav Isakov 2007-04-15 21:59:24 UTC

Created attachment 116345 [details, diff]
files/mplayer-dvd-verbose.patch

patch for mplayer configure

Comment 4 Steve Dibb (RETIRED) gentoo-dev

2007-04-27 20:57:00 UTC

Send the configure script patches upstream, to see if they would take them.  Other than that, the ebuild patch looks good, but the policy is not to forcibly enable anything, which is why you only see --disable flags for those.

Comment 5 Yaroslav Isakov 2007-04-27 23:57:20 UTC

It's already in upstream - please, see comment #2

Comment 6 Yaroslav Isakov 2007-04-28 00:18:15 UTC

Created attachment 117461 [details, diff]
mplayer-1.0_rc2_pre20070321-r4.ebuild.patch v2

Version without --enable-dvdnav

Comment 7 Yaroslav Isakov 2007-04-28 00:23:06 UTC

And BTW, it's need a modification in ogmrip which needed mplayer with dvd flag. I delete this flag because it's not needed (it's replaced by dvdnav flag). It was needed because of dvdnav and dvdread flags. But dvdread didn't do anything! (with "-dvdread -dvdnav" mplayer was compiled with internal dvdread/dvdcss)

Comment 8 Yaroslav Isakov 2007-05-03 20:30:37 UTC

Created attachment 118085 [details, diff]
mplayer-20070427.patch

Updated patch for ebuild without patch for configure (which in upstream)

Comment 9 Steve Dibb (RETIRED) gentoo-dev

2007-05-19 18:14:17 UTC

(In reply to comment #7)
> And BTW, it's need a modification in ogmrip which needed mplayer with dvd flag.
> I delete this flag because it's not needed (it's replaced by dvdnav flag). It
> was needed because of dvdnav and dvdread flags. But dvdread didn't do anything!
> (with "-dvdread -dvdnav" mplayer was compiled with internal dvdread/dvdcss)
> 

That's because the ebuild doesn't include --disable-dvdread-internal, it just disables external dvdread.

Comment 10 Yaroslav Isakov 2007-05-20 09:02:48 UTC

It's internal, so we don't need to disable it anyway

Comment 11 Steve Dibb (RETIRED) gentoo-dev

2007-06-24 23:17:49 UTC

Should be good now, removed 'dvdread' use flag, so now we only have 'dvd' for generic DVD stuff, and 'dvdnav' for new libdvdnav support from upstream.