Bug 173795 - xfce-base/thunar-0.8.0-r2: Command chosen in UCA browse isn't quoted
Bug#: 173795 Product:  Gentoo Linux Version: 2006.1 Platform: All
OS/Version: Linux Status: RESOLVED Severity: trivial Priority: P2
Resolution: FIXED Assigned To: xfce@gentoo.org Reported By: askwar@digitalprojects.com
Component: Applications
URL:  http://bugzilla.xfce.org/show_bug.cgi?id=3105
Summary: xfce-base/thunar-0.8.0-r2: Command chosen in UCA browse isn't quoted
Keywords:  
Status Whiteboard: 
Opened: 2007-04-08 20:04 0000
Description:   Opened: 2007-04-08 20:04 0000 
In Thunar, a user can select a so-called "UCA" (User Configurable Action). In
doing so, he can BROWSE to select a command which is to be run. If the path to
command (including the actual filename) contains spaces, the command is to be
put in quotes. If it's not, when the UCA is selected, nothing will happen, as
the programm cannot be found.

Attached patch fixes this issue. When a user selects (after browsing) a
filename which contains spaces, the quotes (") are put before and after the
filename.

There's also a bug at upstream reg. this -
http://bugzilla.xfce.org/show_bug.cgi?id=3105

------- Comment #1 From Alexander Skwar 2007-04-08 20:06:12 0000 ------- 
Created an attachment (id=115747) [details]
Patch against thunar-uca-editor.c, adding quotes

The attached patch makes it so, that the filename has quotes (") before and
after it, if quotes are required. Right now, it only checks for the occurance
of space.

------- Comment #2 From Alexander Skwar 2007-04-08 20:07:04 0000 ------- 
Forgot to mention the purpose of this bug - I'd like to suggest to add this
patch to a (possible) r3, as it makes Thunar easier and better to use.

------- Comment #3 From Samuli Suominen 2007-04-13 12:18:41 0000 ------- 
Alexander, We'll wait until upstream responses in
http://bugzilla.xfce.org/show_bug.cgi?id=3105 before doing this change.

------- Comment #4 From Samuli Suominen 2007-04-23 12:18:18 0000 ------- 
Upstream is here saying 'This bug should be marked INVALID'.
http://bugzilla.xfce.org/show_bug.cgi?id=3105#c7

If they change their mind, let us know.. ty.

------- Comment #5 From Samuli Suominen 2007-04-25 12:08:02 0000 ------- 
http://bugzilla.xfce.org/show_bug.cgi?id=3105#c11 , status has changed to
upstream patch in form of unapplied patch attached to upstream bug. waiting for
resolution.

------- Comment #6 From Samuli Suominen 2007-05-02 12:34:28 0000 ------- 
(In reply to comment #2)
> Forgot to mention the purpose of this bug - I'd like to suggest to add this
> patch to a (possible) r3, as it makes Thunar easier and better to use.
> 

I applied Nick Schermer's patch from upstream bug in -r3. Thanks for your work
and reporting.