Bug 169825 - mozilla fixes needed for Gentoo/FreeBSD.
Bug#: 169825 Product:  Gentoo/Alt Version: unspecified Platform: All
OS/Version: FreeBSD Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: bsd@gentoo.org Reported By: the_paya@gentoo.org
Component: FreeBSD
URL: 
Summary: mozilla fixes needed for Gentoo/FreeBSD.
Keywords:  
Status Whiteboard: 
Opened: 2007-03-07 20:52 0000
Description:   Opened: 2007-03-07 20:52 0000 
This patch is needed for mozilla-firefox/thunderbird >=2, seamonkey >=1.1.1 and
maybe anything that builds from mozilla sources on Gentoo/FreeBSD for them to
compile and work properly.

------- Comment #1 From Javier Villavicencio 2007-03-07 20:53:03 0000 ------- 
Created an attachment (id=112468) [details]
mozilla-fbsd.patch

The patch is made for firefox but applies with some fuzz to seamonkey.
I haven't tested it yet against thunderbird but it should apply there as well
(and it's needed there too)
By the way, no harm done to linux since these modifications only appear inside
FreeBSD conditionals.

------- Comment #2 From Raúl Porcel 2007-03-07 21:28:17 0000 ------- 
(In reply to comment #1)
Yes, most of the patches apply for all the mozilla products(and if they only
touch configures or makefiles they can be applied to all products, as they use
the same crap build system for all of them). 

Btw the patch to nsprpub is not needed, as we don't use the included nspr/nss.
How is that nss worked without patching it? Or i am missing something?

------- Comment #3 From Javier Villavicencio 2007-03-07 21:33:31 0000 ------- 
(In reply to comment #2)
> Btw the patch to nsprpub is not needed, as we don't use the included nspr/nss.
> How is that nss worked without patching it? Or i am missing something? 
> 

I grepped for configure.in's that would set _PTHREAD_LDFLAGS to -lc_r on
FreeBSD, nss didn't showed in the grep, and the resulting binaries don't show
libc_r.so running a scanelf -nR on the installed files, just like in vanilla
freebsd.

------- Comment #4 From Raúl Porcel 2007-03-07 22:52:35 0000 ------- 
(In reply to comment #3)
> I grepped for configure.in's that would set _PTHREAD_LDFLAGS to -lc_r on
> FreeBSD, nss didn't showed in the grep, and the resulting binaries don't show
> libc_r.so running a scanelf -nR on the installed files, just like in vanilla
> freebsd.
> 

I meant nspr :) What about without applying the nspr patch? Still works?

------- Comment #5 From Javier Villavicencio 2007-03-08 03:34:22 0000 ------- 
(In reply to comment #4)
> 
> I meant nspr :) What about without applying the nspr patch? Still works?
> 

Hmm IIRC I still missed -lpthread in some places and the build failed by just
patching the main configure.in, that's why (then) I looked for other places
where it might be needed and nsprpub/configure.in came up.
Anyway, the whole patch is just fixing *very* outdated(2003/2004?) checks, I
think it's fine to apply it to both files.

------- Comment #6 From Raúl Porcel 2007-03-09 11:47:06 0000 ------- 
Fixed in:
mozilla-firefox 2.0.0.2, patchset 2.0.0.2-0.5
mozilla-thunderbird 2.0_beta2, patchset 2.0_beta2-0.4
seamonkey 1.1.1, patchset 1.1.1-0.2
mozilla-sunbird 0.3.1, patchset 0.3.1-0.2
xulrunner 1.8.0.4, patchset 1.8.0.4-1.0

Happy keywording!