Bug 169588 - app-emacs/*, sci-mathematics/maxima: Emacs site-lisp files should use "add-to-list"
Bug#: 169588 Product:  Gentoo Linux Version: 2006.1 Platform: All
OS/Version: Linux Status: RESOLVED Severity: minor Priority: P3
Resolution: FIXED Assigned To: emacs@gentoo.org Reported By: ulm@gentoo.org
Component: Applications
URL: 
Summary: app-emacs/*, sci-mathematics/maxima: Emacs site-lisp files should use "add-to-list"
Keywords:  
Status Whiteboard: 
Opened: 2007-03-06 10:04 0000
Description:   Opened: 2007-03-06 10:04 0000 
Several of the site-gentoo files installed in /usr/share/emacs/site-lisp use
commands of the following form to add their directory to Emacs's load-path:
   (setq load-path (cons "@SITELISP@" load-path))
This doesn't take existing entries into account and leads to duplications.
   (add-to-list 'load-path "@SITELISP@")
should be used instead.

It is probably not worthwhile to update all packages because of this (several
of the packages are marked stable), but something to keep in mind if a new
revision is released for some other reason.

The list of 58 packages and the script to generate the list will be attached.

(Herds are:
"emacs"+"java" for aspectj4emacs and jde,
"emacs"+"ml" for ocaml-mode,
"emacs"+"net-mail" (maintainer: usata) for wanderlust and wanderlust-cvs,
"sci-mathematics" for maxima,
"emacs" for all others.)

------- Comment #1 From Ulrich Müller 2007-03-06 10:05:35 0000 ------- 
Created an attachment (id=112265) [details]
List of packages affected

------- Comment #2 From Ulrich Müller 2007-03-06 10:06:29 0000 ------- 
Created an attachment (id=112266) [details]
Shell script used for list generation

------- Comment #3 From Christian Faulhammer 2007-03-07 05:56:47 0000 ------- 
(In reply to comment #0)
> It is probably not worthwhile to update all packages because of this (several
> of the packages are marked stable), but something to keep in mind if a new
> revision is released for some other reason.

 That won't work, as I will forget it everytime.  Everything starting wit "A"
and "B" corrected.

 sci-mathematics.  Your site file needs some more work.  Please remove the sed
construct in the ebuild to parse it and use the @SITELISP@ as mentioned in
comment #0.  elisp-common.eclass will take care of it then.

------- Comment #4 From Markus Dittrich 2007-03-08 05:25:01 0000 ------- 
Dear emacs team,

Just if it doesn't cause you guys too much work I would be
very grateful if you could fix the site files for the sci-mathematics
team (aka me). I lack any experience with emacs and don't even 
have it installed on any of my dev boxes.
If it is too much work please let me know and I will certainly try
fixing it myself.

cheers,
Markus

------- Comment #5 From Christian Faulhammer 2007-03-08 07:12:33 0000 ------- 
(In reply to comment #4)
> Just if it doesn't cause you guys too much work I would be
> very grateful if you could fix the site files for the sci-mathematics
> team (aka me). I lack any experience with emacs and don't even 
> have it installed on any of my dev boxes.
> If it is too much work please let me know and I will certainly try
> fixing it myself.

 Done.  Have fun. Next time we will see each other on Macaulay2 stabilisation.

------- Comment #6 From Christian Faulhammer 2007-03-08 10:08:09 0000 ------- 
All fixed...that was boring. :)

Thanks.

------- Comment #7 From Markus Dittrich 2007-03-09 03:43:28 0000 ------- 
Thanks a lot for your help, Christian! It is much appreciated.

Regarding Macaulay - I can't wait! Maybe I should be myself
some more RAM before that;)

cheers,
Markus

------- Comment #8 From Christian Faulhammer 2007-03-09 08:10:34 0000 ------- 
(In reply to comment #7)
> Thanks a lot for your help, Christian! It is much appreciated.

 Just my own interest.

> Regarding Macaulay - I can't wait! Maybe I should be myself
> some more RAM before that;)

 I will stable it on x86 after two weeks minimum, maybe the ATs go over it,
too.