Bug 169477 - media-libs/libsdl-1.2.11-r1 double free
Bug#: 169477 Product:  Gentoo Linux Version: unspecified Platform: x86
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: games@gentoo.org Reported By: loki_val@gentoo.org
Component: Ebuilds
URL: 
Summary: media-libs/libsdl-1.2.11-r1 double free
Keywords:  
Status Whiteboard: 
Opened: 2007-03-05 18:05 0000
Description:   Opened: 2007-03-05 18:05 0000 
Import patches from Debian/Mandriva to fix a number of bugs:

libsdl-1.2.11-supermount-double-free-issue.patch fixes:
Debian 401950 (nexuiz: double free, memory errors)
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=401950
Debian 380508 (libsdl1.2debian: dosbox doesn't start due to invalid free)
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=380508

libsdl-1.2.11-dont-propagate-lpthread.patch
Fixes spurious dependency as reported in Debian 375822
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=375822

libsdl-1.2.11-no-yasm.patch
Fixes bug #163053. Included here because I need it to get libsdl to build
without hacks. Strictly speaking, that libsdl uses yasm in the first place is a
spurious dependency, since libsdl only depends on nasm.

Included for testing of patches: libsdl-1.2.11-r2.ebuild

Reproducible: Always

Steps to Reproduce:

------- Comment #1 From Peter Alfredsen 2007-03-05 18:06:59 0000 ------- 
Created an attachment (id=112190) [details]
libsdl-1.2.11-r2.ebuild

------- Comment #2 From Peter Alfredsen 2007-03-05 18:07:51 0000 ------- 
Created an attachment (id=112192) [details]
dont-propagate-lpthread.patch

------- Comment #3 From Peter Alfredsen 2007-03-05 18:08:25 0000 ------- 
Created an attachment (id=112193) [details]
libsdl-1.2.11-supermount-double-free-issue.patch

------- Comment #4 From Peter Alfredsen 2007-03-05 18:09:27 0000 ------- 
Created an attachment (id=112195) [details]
libsdl-1.2.11-dont-propagate-lpthread.patch

Get name right this time

------- Comment #5 From Peter Alfredsen 2007-03-05 18:10:07 0000 ------- 
Created an attachment (id=112197) [details]
libsdl-1.2.11-no-yasm.patch

------- Comment #6 From Sheldon Hearn 2007-03-09 13:16:32 0000 ------- 
What patches do you remove to make yours build?

I ask because your ebuild and patches cause at least
libsdl-1.2.11-fbcon-page-header.patch to break.

------- Comment #7 From Peter Alfredsen 2007-03-16 11:20:32 0000 ------- 
Created an attachment (id=113468) [details]
libsdl-1.2.11-r1-libsdl-1.2.11-r2.patch

(In reply to comment #6)
> What patches do you remove to make yours build?
> 
> I ask because your ebuild and patches cause at least
> libsdl-1.2.11-fbcon-page-header.patch to break.
> 
I cannot replicate that. I noticed that the fbcon patch has been updated
recently so I added that to my ebuild and rebuilt it. Nowhere does it reject
any patches.
Attached a diff from the current portage ebuild to the one in my overlay.

------- Comment #8 From teidakankan@gmail.com 2007-03-19 09:46:08 0000 ------- 
Thanks for the this ebuild as -r1 wouldn't build for me.  I did have to comment
out this patch as it was not included:

        epatch "${FILESDIR}"/${P}-linux-headers.patch #159923

------- Comment #9 From SpanKY 2007-03-20 03:41:54 0000 ------- 
ive taken the cdrom fix from upstream and added it to 1.2.11-r2 ... the pthread
fix i'll take upstream