Bug 164588

Summary:	app-vim/gentoo-syntax: misc patches for make.conf and use.desc
Product:	Gentoo Linux	Reporter:	Marc Finet <m.dreadlock>
Component:	Current packages	Assignee:	Vim Maintainers <vim>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	truedfx
Priority:	High	Keywords:	InVCS
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Add CAMERAS Add + and . in package names Add CAMERAS Add + and . in package names

Description Marc Finet 2007-01-30 19:03:12 UTC

make.conf is missing the new CAMERAS
use.desc is missing + and . in the package names.


Reproducible: Always

Comment 1 Marc Finet 2007-01-30 19:04:16 UTC

Created attachment 108644 [details, diff]
Add CAMERAS

Comment 2 Marc Finet 2007-01-30 19:05:14 UTC

Created attachment 108646 [details, diff]
Add + and . in package names

Comment 3 Marc Finet 2007-01-30 19:07:05 UTC

Created attachment 108650 [details, diff]
Add CAMERAS

Comment 4 Marc Finet 2007-01-30 19:07:32 UTC

Created attachment 108651 [details, diff]
Add + and . in package names

Comment 5 Mike Kelly (RETIRED) gentoo-dev

2007-01-30 19:56:41 UTC

(In reply to comment #3)
> Created an attachment (id=108650) [edit]
> Add CAMERAS

I don't think I'll add this patch. If you can come up with a patch that dynamically works on all variables in USE_EXPAND, I'll use it. Otherwise, I don't think this is a good idea.

Comment 6 Harald van Dijk (RETIRED) gentoo-dev

2007-01-31 07:02:53 UTC

(In reply to comment #5)
> I don't think I'll add this patch. If you can come up with a patch that
> dynamically works on all variables in USE_EXPAND, I'll use it. Otherwise, I
> don't think this is a good idea.

Does it have to find them all at runtime, or would you be happy with a patch that gets all USE_EXPAND variables when gentoo-syntax is merged? The former is not reasonably possible, but the latter shouldn't be much of a problem.

Comment 7 Mike Kelly (RETIRED) gentoo-dev

2007-02-12 15:07:53 UTC

Hmm, after further discussion w/ some vim folks, doing it dynamically isn't reasonable (too slow at runtime, folks won't have it up-to-date if it's done at install time). I've just applied your USE_EXPAND patch to svn, r24.

Comment 8 Mike Kelly (RETIRED) gentoo-dev

2007-02-12 15:17:11 UTC

Your other patch is not correct. You patched the line for what characters are allowed in a USE flag name, not the line for what is allowed in a package name.

Comment 9 Mike Kelly (RETIRED) gentoo-dev

2007-02-12 15:45:50 UTC

I've fixed gentoo-use-desc.vim properly in svn, r25 and r26.

This will all be in the next release of gentoo-syntax (probably later tonight).

Comment 10 Mike Kelly (RETIRED) gentoo-dev

2007-02-13 04:47:34 UTC

Fixed in 20070212 release, which should hit mirrors in a few hours.