Bug 162841 - dos2unix -> edos2unix conversion
Bug#: 162841 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: media-video@gentoo.org Reported By: cl81@gmx.net
Component: Ebuilds
URL: 
Summary: dos2unix -> edos2unix conversion
Keywords:  
Status Whiteboard: 
Opened: 2007-01-19 19:32 0000
Description:   Opened: 2007-01-19 19:32 0000 
Grepping in the current portage tree reveals that there are some programs using
"dos2unix" without RDEPEND'ing on it. So they mainly use it in the ebuild
itself. Since there is an edos2unix function in current stable portage
available, using this and dumping the dos2unix DEPEND would be nice.

I did not verify, if dos2unix definitely isn't used by the programs. It would
be nice to clarify this.

The following packages are affected:
net-mail/gml-0.5
games-board/freedoko-0.7.3
media-video/vstrip-0.8f


Reproducible: Always

Steps to Reproduce:
1. find /usr/portage -name "*.ebuild" -exec egrep -H "(unix|dos)2(dos|unix)" {}
\; | grep -v edos2unix
2. use your eyes on the results.
Actual Results:  
./net-mail/gml/gml-0.5.ebuild:  app-text/dos2unix"
./net-mail/gml/gml-0.5.ebuild:  dos2unix -o gmlw.py
./games-board/freedoko/freedoko-0.7.3.ebuild:   app-text/dos2unix"
./games-board/freedoko/freedoko-0.7.3.ebuild:   dos2unix
${S}/src/Makefile.rules
./media-video/vstrip/vstrip-0.8f.ebuild:DEPEND="app-text/dos2unix
./media-video/vstrip/vstrip-0.8f.ebuild:        dos2unix -q -o *.c *.h

[and some irrelevant ones]


Expected Results:  
Not the ones mentioned above.

------- Comment #1 From Jakub Moc (RETIRED) 2007-01-19 21:12:40 0000 ------- 
(In reply to comment #0)
> Grepping in the current portage tree reveals that there are some programs using
> "dos2unix" without RDEPEND'ing on it. 

Why should they RDEPEND on it? It's not a runtime dependency at all; the deps
are just fine...

------- Comment #2 From Charlie Shepherd (RETIRED) 2007-01-19 21:55:06 0000 ------- 
(In reply to comment #0)
> Grepping in the current portage tree reveals that there are some programs using
> "dos2unix" without RDEPEND'ing on it. So they mainly use it in the ebuild
> itself. Since there is an edos2unix function in current stable portage
> available, using this and dumping the dos2unix DEPEND would be nice.

dos2unix is a function in eutils.eclass, not a package....

------- Comment #3 From Jakub Moc (RETIRED) 2007-01-19 22:27:04 0000 ------- 
(In reply to comment #2)
> dos2unix is a function in eutils.eclass, not a package.... 

Nope, that's edos2unix :)

------- Comment #4 From Mr. Bones. 2007-01-19 22:29:44 0000 ------- 
freedoko fixed.

------- Comment #5 From Charlie Shepherd (RETIRED) 2007-01-19 23:01:07 0000 ------- 
(In reply to comment #3)
> (In reply to comment #2)
> > dos2unix is a function in eutils.eclass, not a package.... 
> 
> Nope, that's edos2unix :) 

:( i guess i'll just go and be quiet over here then...

------- Comment #6 From Andrej Kacian (RETIRED) 2007-01-19 23:02:18 0000 ------- 
gml fixed

------- Comment #7 From Samuli Suominen 2007-03-31 19:28:11 0000 ------- 
media-video/vstrip converted to edos2unix.. the package is borqued in many
different ways, it was least of it's worries.