Bug 162239 - Kernel patch for S-Video/Composite-Input of the Terratec Cinergy 1400 DVB-T
Bug#: 162239 Product:  Gentoo Linux Version: 2006.1 Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: dsd@gentoo.org Reported By: heiko@baums-on-web.de
Component: Core system
URL:  http://bugzilla.kernel.org/show_bug.cgi?id=7830
Summary: Kernel patch for S-Video/Composite-Input of the Terratec Cinergy 1400 DVB-T
Keywords:  
Status Whiteboard: 
Opened: 2007-01-15 17:57 0000
Description:   Opened: 2007-01-15 17:57 0000
Please, apply the attached patch to the kernel, at least to gentoo-sources.

The file /usr/src/linux/drivers/media/video/cx88/cx88-cards.c needs to be
patched to get the combined S-Video/Composite input of the Terratec Cinergy
1400 DVB-T working.

The patch I've made is for gentoo-sources-2.6.19-r4.

It would be nice if this would also go into the other kernel sources.

Btw, ".vmux = 2" is in both cases correct because this DVB-T card has only one
input which is a combined S-Video/Composite input. How the input source has to
be interpreted has to be set by the parameters/options of the capturing
software like tvtime or mplayer.

The picture quality for me is not the best but I don't know if and I don't
think that this is kernel related. But maybe someone can have a look at this,
too, if this can be tuned in the kernel.

I don't know the functions of the gpio values in some of the other card
descriptions in this file. So I don't know if it's necessary to set such a gpio
value and to which value it has to be set to. But I'm getting a picture without
it.

------- Comment #1 From Heiko Baums 2007-01-15 17:59:05 0000 -------
Created an attachment (id=107079) [details]
cx88-cards.c.diff

The kernel patch to get the combined S-Video/Composite input of the Terratec
Cinergy 1400 DVB-T working.

------- Comment #2 From Jakub Moc (RETIRED) 2007-01-15 18:30:31 0000 -------
This needs to be submitted upstream, not to Gentoo...

http://dev.gentoo.org/~dsd/genpatches/faq.htm

------- Comment #3 From Daniel Drake 2007-01-15 18:46:39 0000 -------
Are you the author of this patch?

------- Comment #4 From Heiko Baums 2007-01-15 19:15:32 0000 -------
Over a year ago I've found a similar patch for an older kernel version
somewhere in a forum in the internet. I don't know where anymore.

Because I haven't saved the patch and need this function again I just rewrote
it from what I remembered. So principally I am the author of this patch but it
depends on another possibly slightly different patch.

------- Comment #5 From Heiko Baums 2007-01-15 21:35:42 0000 -------
Filed a bug report upstream:
http://bugzilla.kernel.org/show_bug.cgi?id=7830

------- Comment #6 From Heiko Baums 2007-01-21 05:01:54 0000 -------
Created an attachment (id=107627) [details]
cx88-cards.c.patch

A slightly modified patch as asked by upstream's documentation for submitting
patches.

------- Comment #7 From Daniel Drake 2007-01-21 18:04:00 0000 -------
patch accepted upstream

------- Comment #8 From Matthias Schwarzott 2007-01-22 09:58:28 0000 -------
You could use v4l-dvb-hg until patch makes it into an official kernel-version.

------- Comment #9 From Heiko Baums 2007-01-22 10:17:22 0000 -------
If you mean me, I know. Because I have written this patch it's already in my
kernel. ;-)

For any other people of course you are right.

------- Comment #10 From Daniel Drake 2007-01-29 18:18:02 0000 -------
Fixed in gentoo-sources-2.6.19-r5