Bug 161089 - [PATCH for gnome-vfs] gnome_vfs_url_show_with_env does not work if entry in *.desktop is empty Path: 'Path='.
|
Bug#:
161089
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: normal
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: gnome@gentoo.org
|
Reported By: pva@gentoo.org
|
|
Component: GNOME
|
|
|
URL:
http://bugzilla.gnome.org/show_bug.cgi?id=389273
|
|
Summary: [PATCH for gnome-vfs] gnome_vfs_url_show_with_env does not work if entry in *.desktop is empty Path: 'Path='.
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2007-01-09 10:21 0000
|
I was assured that there will be no gnome-vfs releases for 2.16 so I'd like to
see this patch added into current gnome-vfs. The patch is applied upstream so I
think it's good idea to follow. :) If gnome herd permits I could add this
patch.
Patch for gnome-vfs and ebuild follow.
And this is mail from gnome-vfs maintainer Alexander Larsson where he suggests
to add it into our tree:
**************************begin of mail********************************
On Mon, 2007-01-08 at 20:17 +0300, Peter Volkov (pva) wrote:
> On Пнд, 2007-01-08 at 15:31 +0100, Alexander Larsson wrote:
> > On Mon, 2006-12-25 at 17:17 +0300, Peter Volkov (pva) wrote:
> > > There is a bug in gnome-vfs when it does not work in the case when there
> > > is the 'Path=' entry in .desktop file.
> >
> > I'm commiting something similar:
> >
> > + if (app->priv->path != NULL && *app->priv->path == 0) {
> > + g_free (app->priv->path);
> > + app->priv->path = NULL;
> > + }
>
> Thank you. A short question: are you going to release gnome-vfs-2.16.4?
> Or is it a good idea to apply this patch for gnome-vfs-2.16.3 in gentoo?
There is no 2.16 release planned soon, so patching it sounds better.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
***************************end of mail*********************************
Any progress here? I could commit this by myself, but I'd like to have
permission from gnome team. This patch IS commited upstream. ;)
Sorry, I was going to test and commit this, buy my dev box is broken and not
booting.
The patch looks simple enough, go ahead and commit it.
Thank you for reviewing the patch. commited. :)
Hope, you'll fix your box soon.