Summary: | dev-util/subversion - 70svn-gentoo.el confuses emacs-cvs libraries | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Timothy Stotts <devel> |
Component: | New packages | Assignee: | Emacs project <emacs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | chtekk, ediap, pauldv, tsdh, ulm |
Priority: | High | Keywords: | REGRESSION |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Proposed new 70svn-gentoo.el
Proposed patch for subversion-1.4.3.ebuild Proposed patch for subversion-1.4.3.ebuild (take 2) |
Description
Timothy Stotts
2006-12-23 00:43:00 UTC
I'd prefer your second solution. The vc-svn.el script is a file in the tree so any better version would do (as long as it is compatible) Another possibility would be to install vc-svn.el* in a different directory (say, ${SITELISP}/${PN}/compat). Then the site-init file could add it to the load-path for Emacs versions < 22 only: (add-to-list 'load-path "@SITELISP@") (and (< emacs-major-version 22) (add-to-list 'load-path "@SITELISP@/compat")) (In reply to comment #2) That would be an excellent solution. One caveat though. Emacs 22 appears to recursively search the site-lisp directory for elisp files; so even if the directory is not explicitly add to `load-path', if it is under a directory in the path, it will still be found by `locate-library'. IMHO, a better solution would be to install `vc-svn.el' at /usr/share/subversion/emacs/ in similar fashion to `clisp' and other portage packages. Then site the load file can conditionally add that directory the `load-path' base on the Emacs major version. (In reply to comment #3) > One caveat though. Emacs 22 appears to recursively search the site-lisp > directory for elisp files; so even if the directory is not explicitly > add to `load-path', if it is under a directory in the path, it will still > be found by `locate-library'. You are right, load-path is augmented by its subdirs in startup.el (function normal-top-level-add-subdirs-to-load-path). This can be prevented by placing a file ".nosearch" within the subdir. So in addition to my comment #2, the ebuild should also install an empty file ".nosearch" in the "compat" directory. Created attachment 111101 [details]
Proposed new 70svn-gentoo.el
Created attachment 111102 [details, diff]
Proposed patch for subversion-1.4.3.ebuild
Created attachment 111111 [details, diff]
Proposed patch for subversion-1.4.3.ebuild (take 2)
What is the say of the emacs maintainers on this? It seems to be a sane solution, but I'd like your view on it. (In reply to comment #8) > What is the say of the emacs maintainers on this? It seems to be a sane > solution, but I'd like your view on it. Ulrich is an Officially Trusted Emacs User(TM). :) But I am ok with it, looks fine. Thanks Ulrich, as always. While you are at it: Is there a special reason why pkg_postrm() does: has_version virtual/emacs && elisp-site-regen instead of: use emacs && elisp-site-regen which is used in pkg_postinst() (and is the more usual way)? (In reply to comment #10) > While you are at it: > Is there a special reason why pkg_postrm() does: > has_version virtual/emacs && elisp-site-regen > instead of: > use emacs && elisp-site-regen > which is used in pkg_postinst() (and is the more usual way)? I fixed that, pauldv, I hope you don't mind. The rest has been already handled, so this bug can be closed. Both problems (comment #7 and comment #10) reappeared in 1.4.4-r2, therefore reopening. Versions 1.4.3 up to 1.4.4-r1 were O.K. *** Bug 185427 has been marked as a duplicate of this bug. *** Fixed again in 1.4.4-r3, as discussed with phreak on IRC. |