Bug 158727 - update for app-pda/dopi to 0.3.4
|
Bug#:
158727
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: dotnet@gentoo.org
|
Reported By: dieterv@optionexplicit.be
|
|
Component: Ebuilds
|
|
|
URL:
http://www.snorp.net/log/dopi/
|
|
Summary: update for app-pda/dopi to 0.3.4
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2006-12-21 06:02 0000
|
dopi has been updated to 0.3.4 since Oct 23
Created an attachment (id=104506) [details]
ebuild for dopi 0.3.4
It no longer supports parallel building, otherwise you would get this:
Making all in taglib-sharp
make[1]: Entering directory
`/var/tmp/portage/app-pda/dopi-0.3.4/work/dopi-0.3.4/taglib-sharp'
/usr/bin/gmcs -debug -out:../taglib-sharp/taglib-sharp.dll -target:library
-r:Mono.Posix ./TagLib/*.cs ./TagLib/*/*.cs ./TagLib/*/*/*.cs
make[1]: *** No rule to make target `../taglib-sharp/taglib-sharp.dll.mdb',
needed by `all-am'. Stop.
May I add here that dopi needs glade-sharp as well in order to compile. So, you
might wanna add it to the DEPEND list.
Created an attachment (id=104708) [details]
added >=dev-dotnet/glade-sharp-2.4.0 to DEPEND
First of all, a Merry Christmas to you all :)
Indeed, src/Makefile.am has glade-sharp-2.0 in DOPI_ASSEMBLIES. Thanks for
catching that.
Thanks for posting the ebuild. Few more things to do here:
1. Fix the header (see /usr/portage/skel.ebuild)
2. You could use ${PN} in SRC_URI instead of "dopi"
3. Rather than setting 'MAKEOPTS="${MAKEOPTS} -j1"' declare src_compile() and
call 'emake -j1 || die ...' inside it (of course you still have to call econf
as well ;))
4. I think you should update the desktop database after unmerging the package
as well (pkg_postrm())
Created an attachment (id=109285) [details]
dopi-0.3.4-r2.ebuild
Glad to be of help :)
1. Done. Also fixed copyright year.
2. Done.
3. Correct! I wasn't sure what method to use, as both can be found
in lot's of packages in the tree. However, the ebuild howto specifies
your method for the emake command
(http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1#doc_chap4).
Fixed :)
4. It's already there, in pkg_postinst(). I copied that technique from other
ebuilds in the tree. In fact, I couldn't find any ebuild doing it in
pkg_postrm().
I did, however, forget to add fdo-mime_mime_database_update, as the
.desktop file specifies MimeType=... Also fixed.
Ok, builds fine now. However, when there is no gnome-dev-ipod icon in the
default icon theme you get an exception:
Unhandled Exception: GLib.GException: Icon 'gnome-dev-ipod' not present in
theme
at Gtk.IconTheme.LoadIcon (System.String icon_name, Int32 size,
IconLookupFlags flags) [0x00000]
at Dopi.DopiWindow..ctor () [0x00000]
at Dopi.EntryPoint.Main (System.String[] args) [0x00000]
Software that throws an exception whenever an icon is missing is evil. Try
adding the patch (just wrote it) to your ebuild. It's already been sent
upstream.
Oh, and if there is no good reason (and that's the case) for appending r2 to
the version of initial ebuild, simply drop it ;)
Ok. Fixed in CVS, thanks! And do not hesitate to send the patch to upstream as
well.
