Bug 157826 - dev-java/swt patching
Bug#: 157826 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: java@gentoo.org Reported By: h.mth@web.de
Component: Ebuilds
URL:  https://overlays.gentoo.org/proj/java/browser/other/eclipse-patches/3.2.1/eclipse-sdk-3.2.1-swt-rm-ON_TOP.patch
Summary: dev-java/swt patching
Keywords:  
Status Whiteboard: 
Opened: 2006-12-11 07:03 0000
Description:   Opened: 2006-12-11 07:03 0000 
Hi! The patch on URL should be applied for dev-java/swt, shouldn't it?
Btw, isn't that xpcomgcc4 patch obsolete? Fedora, at least, does not apply it
anymore. Just wondering. :)

------- Comment #1 From Jakub Moc (RETIRED) 2006-12-11 13:57:06 0000 ------- 
Sigh, how about describing what you want to patch and why?

------- Comment #2 From Hanno Meyer-Thurow 2006-12-11 14:22:53 0000 ------- 
Sigh, why should one version of swt (the one from eclipse-sdk) be patched and
the external from dev-java/swt not? ;)

Well, looking at the bugreport [1] it is fixed in 3.2.1. So it can be dropped
from eclipse-sdk-3.2.1(-r1).

Still, I am wondering about eclipse-sdk-3.2.1-libswt-xpcomgcc4.patch, see
bugreport [2].


[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=142861
[2] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200929

------- Comment #3 From Hanno Meyer-Thurow 2006-12-12 00:36:15 0000 ------- 
I built dev-java/swt against firefox 2.0 and the SWT Browser does fine without
that xpcomgcc4 patch.
So, for x86 that patch is obsoleted by Fedoras firefox patch. I guess for other
archs, too.

------- Comment #4 From Vlastimil Babka (Caster) 2006-12-12 03:57:42 0000 ------- 
We are currently building against seamonkey and there the patch is needed (see
bug 156716, bug 156716, bug 157510 ...)

------- Comment #5 From Hanno Meyer-Thurow 2006-12-12 07:10:40 0000 ------- 
Right, firefox.patch is correct, xpcomgcc4.patch is obsolete.

------- Comment #6 From Hanno Meyer-Thurow 2006-12-12 07:17:57 0000 ------- 
I mean, if you have had a look at Fedoras bugreport you would have seen that
the xpcomgcc4.patch is obsoleted by the firefox.patch.

Fedora build swt without xpcomgcc4.patch for any arch. I bet they have no magic
there. ;)

------- Comment #7 From Hanno Meyer-Thurow 2006-12-23 03:02:55 0000 ------- 
Created an attachment (id=104621) [details]
more cairo signedness warning fixes; arch-independent?

------- Comment #8 From Petteri Räty 2007-03-04 14:09:28 0000 ------- 
(In reply to comment #7)
> Created an attachment (id=104621) [edit] [details]
> more cairo signedness warning fixes; arch-independent?
> 

Is this something you wrote or already upstream? I would like to see as much
going upstream as possible.

------- Comment #9 From Hanno Meyer-Thurow 2007-03-04 14:39:01 0000 ------- 
I use swt-3.3M5 now. There are no signedness patches needed anymore afair.
And that xpcomgcc4.patch code went upstream, too.

------- Comment #10 From Petteri Räty 2007-03-05 12:36:55 0000 ------- 
(In reply to comment #9)
> I use swt-3.3M5 now. There are no signedness patches needed anymore afair.
> And that xpcomgcc4.patch code went upstream, too.
> 

I guess it's best to wait for 3.3* and the warnings will go away there. Is your
cairo patch needed for anything else than silencing warnings? But to me casting
around problems looks nasty.

------- Comment #11 From Hanno Meyer-Thurow 2007-03-05 12:57:16 0000 ------- 
Nothing else did the other patches do. ;)

------- Comment #12 From Petteri Räty 2007-03-05 14:12:47 0000 ------- 
(In reply to comment #11)
> Nothing else did the other patches do. ;)
> 

Heh. Your patch applied on ppc and amd64 so I added it to 3.2.2. I dropped the
xpcom4 patch from all but amd64 because I guess it could be still needed there.
If there is anything you want to change in 3.2.2 wrt patches please let me
know.

 https://overlays.gentoo.org/svn/proj/java/other/swt-patches