Bug 157752 - media-sound/amarok-1.4.4-r2 device mtp support: errors with non-ASCII text
|
Bug#:
157752
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: x86
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: normal
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: flameeyes@gentoo.org
|
Reported By: grmcdorman@gmail.com
|
|
Component: Applications
|
|
|
URL:
http://bugs.kde.org/show_bug.cgi?id=129801
|
|
Summary: media-sound/amarok-1.4.4-r2 device mtp support: errors with non-ASCII text
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2006-12-10 11:44 0000
|
When transferring tracks to a media device [MP3 player] with non-ASCII
characters - i.e. characters outside of the 0-FF standard ASCII range - Amarok
will either create incorrect strings or fail to transfer the affected file.
Similarly, in the list of device tracks, strings containing these characters do
not display correctly.
For example,
When transferring tracks to a media device [MP3 player] with non-ASCII
characters - i.e. characters outside of the 0-FF standard ASCII range - Amarok
will either create incorrect strings or fail to transfer the affected file.
Similarly, in the list of device tracks, strings containing these characters do
not display correctly.
For example, ç (c-cedilla) will display as ç (tilde-capital A, section).
Tracks with 'é' in the resulting media device filename will not transfer at
all.
Inspecting the source, it looks like 'mtpmediadevice.cpp' is converting strings
to UTF8 where Latin1, presumably, should be used. It is not immediately clear
from the source where the reverse conversion would apply.
The libmtp documentation does not specify which charset should be used, but it
does appear that Latin1, not UTF8, should be used.
The media device being used is a Creative Zen MicroPhoto.
This applies to amarok 1.4.4 R2 ebuild.
FYI, I poked around in bugs.kde.org; this is apparently fixed in the amarok SVN
repository (see, e.g, http://bugs.kde.org/show_bug.cgi?id=129801).
I've generated a patch based on that and am trying it out now. If it works, I
will not submit a bug to KDE (and will attach a patch here).
Please just give me the SVN revision or attach the patch in unified format
(diff -u).
Created an attachment (id=103768) [details]
Unified diff version of patch
Sorry, I was not aware that patches were required in unified format.
This is the full output of svn info on the file (unfortunately I'm not
conversant with svn, so I don't know if this is what you need). If it's any
help, I just checked out the svn tree today.
Path: mtpmediadevice.cpp
Name: mtpmediadevice.cpp
URL:
svn://anonsvn.kde.org/home/kde/trunk/extragear/multimedia/amarok/src/mediadevice/mtp/mtpmediadevice.cpp
Repository Root: svn://anonsvn.kde.org/home/kde
Repository UUID: 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
Revision: 612302
Node Kind: file
Schedule: normal
Last Changed Author: kelk
Last Changed Rev: 611972
Last Changed Date: 2006-12-10 01:02:33 -0500 (Sun, 10 Dec 2006)
Text Last Updated: 2006-12-10 15:14:05 -0500 (Sun, 10 Dec 2006)
Properties Last Updated: 2006-12-10 15:14:05 -0500 (Sun, 10 Dec 2006)
Checksum: a2eab81e4e02b9ff89e691ab31fa627a
I was waiting for Luis to add libkarma to the tree to do just one bump adding
this and Rio Karma support, but I'll just apply this tonight now.