Bug 157434 - xfce-extra/xfmedia (revised)
Bug#: 157434 Product:  Gentoo Linux Version: 2006.1 Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: xfce@gentoo.org Reported By: msid@daemons.gr
Component: Ebuilds
URL: 
Summary: xfce-extra/xfmedia (revised)
Keywords:  
Status Whiteboard: 
Opened: 2006-12-07 07:55 0000
Description:   Opened: 2006-12-07 07:55 0000 
A revised ebuild for xfce-extra/xfmedia. Adds 3 USE flags as well, dbus, debug
and startup-notification. Much more compact, stripped the unnecassary stuff.

------- Comment #1 From Sideris Michael 2006-12-07 07:58:24 0000 ------- 
Created an attachment (id=103545) [details]
xfce-extra/xfmedia (revised)

------- Comment #2 From Jakub Moc (RETIRED) 2006-12-07 08:01:30 0000 ------- 
(From update of attachment 103545 [details])
The dbus dependency is broken, please revert the change.

------- Comment #3 From Sideris Michael 2006-12-07 08:40:01 0000 ------- 
Created an attachment (id=103547) [details]
xfce-extra/xfmedia-0.9.2.ebuild (fixed the dbus deps)

------- Comment #4 From Josh Nichols (RETIRED) 2006-12-07 10:35:37 0000 ------- 
One problem: it wouldn't actually build anything :) you defined src_compile
with econf, but make doesn't invoke.

There are ways to use the eclass in such a way that you don't have to redfine
src_compile:

define XFCE_CONFIG to be "$(use_enable debug) $(use_enable
startup-notification) $(use_enable dbus)"

xfce44_src_compile calls 'econf ${XFCE_CONFIG}', so defining XFCE_CONFIG in the
ebuild will ensure that they get passed to configure.

------- Comment #5 From Sideris Michael 2006-12-07 10:49:42 0000 ------- 
Created an attachment (id=103561) [details]
xfce-extra/xfmedia-0.9.2-r1.ebuild

I guess this makes it final. Using the XFCE_CONFIG this time.

------- Comment #6 From Josh Nichols (RETIRED) 2006-12-07 11:01:47 0000 ------- 
Sorry... one last thing, probably want to set RDEPEND=${DEPEND}, as you'd
likely need things like gtk at runtime :)

------- Comment #7 From Sideris Michael 2006-12-07 12:09:53 0000 ------- 
Created an attachment (id=103566) [details]
xfce-extra/xfmedia-0.9.2-r1.ebuild

Done.

------- Comment #8 From Josh Nichols (RETIRED) 2006-12-10 18:14:50 0000 ------- 
Suggestions applied, thanks for reprorting.

Just one thing to note, if you have USE based deps, there needs to be a space
after the openning ( and before the closing ), ie "foo? ( xfce-base/xfce4-foo
)"