Bug 157021 - media-tv/wis-go7007 needs a patch to work with latest kernels
Bug#: 157021 Product:  Gentoo Linux Version: 2006.1 Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: beandog@gentoo.org Reported By: vrtladept@gmail.com
Component: Ebuilds
URL: 
Summary: media-tv/wis-go7007 needs a patch to work with latest kernels
Keywords:  
Status Whiteboard: 
Opened: 2006-12-03 14:42 0000
Description:   Opened: 2006-12-03 14:42 0000
I've attached a patch I use to get the wis-go7007 driver to compile.  This
patch has worked on my system since kernel version 2.6.17 and I have recently
used it with kernel 2.6.18.3 (just compiled and worked).  Seems to work great
on my amd64 system using mythtv.



# emerge --info
Portage 2.1.1-r2 (default-linux/amd64/2006.1/desktop, gcc-4.1.1, glibc-2.4-r4,
2.6.18-gentoo-r2 x86_64)
=================================================================
System uname: 2.6.18-gentoo-r2 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor
3800+
Gentoo Base System version 1.12.6
Last Sync: Sun, 03 Dec 2006 03:30:01 +0000
ccache version 2.3 [enabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=k8"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=k8"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/linux/distributions/gentoo"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/portage/local/layman/sunrise"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aim alsa amd64 arts avi berkdb bitmap-fonts cairo cdparanoia cdr cli
cracklib crypt css cups dbus divx4linux dlloader dri dv dvb dvd dvdr dvdread
eds elibc_glibc emboss encode esd fam firefox flac flame fmpeg font-server
fortran gdbm gif gpm gstreamer gtk gtk2 hal iconv icq input_devices_keyboard
input_devices_mouse ipod ipv6 isdnlog java jikes joystick jpeg kde kernel_linux
ldap libg++ lirc lirc_devices_streamzap mad mikmod mime mozilla mp3 mpeg msn
musicbrainz mysql ncurses net nls nptl nptlonly nsplugin nvidia ogg oggvorbis
opengl oss pam pcre perl png ppds pppd python qt qt3 qt4 quicktime readline
reflection samba sdl session spell spl ssl streamzap subtitles tcpd truetype
truetype-fonts type1-fonts udev unicode userland_GNU vcd video_cards_fbdev
video_cards_nv video_cards_nvidia video_cards_vesa vorbis widescreen xcomposite
xine xml xorg xv xvid xvmc yahoo zeroconf zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS,
LINGUAS, PORTAGE_RSYNC_EXTRA_OPTS

------- Comment #1 From Brian Long 2006-12-03 14:43:16 0000 -------
Created an attachment (id=103288) [details]
Patch to get wis-go7007 to compile on newer kernels.

------- Comment #2 From Greg Smolyn 2006-12-17 15:25:45 0000 -------
Created an attachment (id=104247) [details]
Patch to make wis drivers run on kernel 2.6.19

snd_card_free_in_thread is deprecated (and thus missing) in the ALSA in kernel
2.6.19.  

I've replaced it with a call to snd_card_free.  This seems to work, although
I'm not quite sure if this is the entirely correct solution.  However, in a
pinch it'll work.

This patch includes the patch posted above.

------- Comment #3 From Brian Long 2006-12-18 09:21:09 0000 -------
I should note that the original patch I posted is needed for 2.6.17 and 2.6.18
(as the package is currently in portage, it will only compile for kernel 2.6.16
and possibly older kernels.)  The best solution (IMHO) would be to update the
ebuild so that it would apply the first patch for kernel 2.6.17 or 2.6.18 and
apply the new patch submitted by Greg for kernel 2.6.19

------- Comment #4 From Daniel Drake 2006-12-30 17:39:38 0000 -------
Patch looks good except:

 - it includes a temporary file copy
 - you should use snd_card_free_when_closed() instead of _free_in_thread

dropping block on 156669 as this is not a 2.6.19 regression

------- Comment #5 From Greg Smolyn 2007-01-22 01:27:18 0000 -------
Created an attachment (id=107744) [details]
Updated patch for module to compile in 2.6.19 kernel

Driver patch fixed as per previous comment.

------- Comment #6 From Matthias Schwarzott 2007-04-26 16:46:57 0000 -------
I combined your patches into one and added it to ebuild 0.9.8-r1.
Thanks for the patches.