Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!

Full Text Bug Listing

some ebuild enhancements:
-fixed jack support (dep use)
-fixed use handling

Created an attachment (id=101778) [details]
ebuild patch from 1.0.7

ebuild 1.0.7 patch, some enhancements

Thanks for the patch, but it's not yet ready for commit:

- when enabling lash and not enabling alsa, the ebuild should not die (don't
tell me, I'd prefer it to die, but that's the policy), so it should indeed
warn, but not fail, instead it should either enable ALSA silently (preferred)
or disable lash altogether;
- no need for the double flags on use_enable when they are the same;
- is static useflag used to generate static libraries or static executable? if
it's for static libraries, remove the useflag and let it always build static
libraries aside from shared ones;
- coreaudio is OSX stuff, leave it disabled until the ebuild is picked up by
the OSX guys.

Created an attachment (id=107926) [details]
corrected patch

Looks like the reporter didn't provide corrected version of the patch, so I
created my own.

Notes:
- preserved most ideas of original patch
- ebuild doesn't die, only prints a warning
- corrected double flags in use_enable
- static USE-flag was there before; didn't touch it
- removed coreaudio from previous patch
- looks like the ./configure script ignores use_enable for alsa and oss
- I'm not sure about --disable-ladcca option passed to econf; it was in the
previous patch so I preserved it

I've reworked the patch a bit, cleaned up the ebuild a bit, and committed it in
1.0.7a.