| Summary: | mozilla-firefox-2.0 BUILD_ID=00000000 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Walter Meinl <wuno> |
| Component: | Eclasses | Assignee: | Mozilla Gentoo Team <mozilla> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | 2006.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
already fixed in the tree thanks Stefan, I reopened this, cause I think its a misunderstanding the lines # echo "export BUILD_OFFICIAL=1" >>.mozconfig # echo "export MOZILLA_OFFICIAL=1" >>.mozconfig # echo "mk_add_options BUILD_OFFICIAL=1" >>.mozconfig # echo "mk_add_options MOZILLA_OFFICIAL=1" >>.mozconfig were introduced here http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/mozcoreconf.eclass?r1=1.9&r2=1.10 However, they are not used in an intree build as gentoo does. mk_add_options is only used by client.mk, when you're building with "make -f client.mk build"(e.g. on a standalone system as win). (In reply to comment #2) So, what we have to do? (In reply to comment #3) > (In reply to comment #2) > > So, what we have to do? > To remove those lines from the mozcoreconf.eclass (the exports are also not in environment.bz2 in contrast to mozilla-thunderbird) and put the exports back in the mozilla-firefox-xxxx.ebuild. Maybe it would work, if we put the exports in the eclass (not echoing them to .mozconfig), but the mk_add_options are useless in any case. As pointed out in comment #0 we could also remove --enable-svg-renderer=cairo and --enable-default-toolkit=gtk2 from the eclass as they are the default settings (we would need these options only if we wanted other svg-renederes or toolkits, respectively). Right, fixed in seamonkey, mozilla-sunbird, and mozilla-firefox. Thanks |
Since setting MOZILLA_OFFICIAL and BUILD_OFFICIAL moved to the mozcorconf.eclass I see during build of mozilla-firefox BUILD_ID=000000. I assume this is due to the fact, that we do not use client.mk for building. mk_add_options is not used by configure but by client.mk. As we probably want to have this set, I'd suggest to export to remove the new function # Add all the variables for building the final product. #mozconfig_build_opts() { # echo "export BUILD_OFFICIAL=1" >>.mozconfig # echo "export MOZILLA_OFFICIAL=1" >>.mozconfig # echo "mk_add_options BUILD_OFFICIAL=1" >>.mozconfig # echo "mk_add_options MOZILLA_OFFICIAL=1" >>.mozconfig #} and put export BUILD_OFFICIAL=1 and export MOZILLA_OFFICIAL=1 up to the other exports we do in the mozcoreconf.eclass, this works here. While I'm on it, maybe for clean up, we do not need any longer --enable-svg-renderer=cairo and --enable-default-toolkit=gtk2 as these are set as defaults on linux (just for some clean up) for ff-1.5+ (ff-1.0.7 that might need this settings doesn't inherit the mozcoreconf.eclass)