Bug 149308 - sys-fs/multipath-tools 0.4.7 wrong path in init script
Bug#: 149308 Product:  Gentoo Linux Version: 2006.1 Platform: AMD64
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: base-system@gentoo.org Reported By: jiri.tyr@e-learning.tul.cz
Component: Ebuilds
URL: 
Summary: sys-fs/multipath-tools 0.4.7 wrong path in init script
Keywords:  
Status Whiteboard: 
Opened: 2006-09-27 07:50 0000
Description:   Opened: 2006-09-27 07:50 0000 
I have installed sys-fs/multipath-tools 0.4.7 and I have found an error in the
init.d script. In /etc/init.d/multipathd file is path /usr/sbin/multipathd and
it should be /sbin/multipathd. Also, when I try to stop already started
multipathd daemon, it do not stop it and I have to kill it manualy.

------- Comment #1 From Jiri Tyr 2006-09-27 23:37:57 0000 ------- 
One more thing is not correct. If I add alias into the multipath.conf, it do
not create the /dev/mapper/alias_name. I think it is because of the udev
configuration.

------- Comment #2 From SpanKY 2006-09-28 01:54:46 0000 ------- 
fixed in 0.4.7-r1, thanks for the report !

------- Comment #3 From Jiri Tyr 2006-09-29 01:33:46 0000 ------- 
(In reply to comment #2)
> fixed in 0.4.7-r1, thanks for the report !

It still doesn't create the alias. In "man devmap_name" is mentioned something
else then what is in /etc/udev/rules.d/40-multipath.rules:

KERNEL="dm-[0-9]*", PROGRAM="/sbin/devmap_name %M %m", \
NAME="%k", SYMLINK="%c"

It would be nice to have alias instead of the bloody mplath device name.

------- Comment #4 From Jiri Tyr 2006-10-04 02:36:46 0000 ------- 
(In reply to comment #3)
> (In reply to comment #2)
> > fixed in 0.4.7-r1, thanks for the report !
> 
> It still doesn't create the alias.

OK, it was my fault. I had badly defined device in multipath.conf.

But it still doesn't stops multipathd if I use the "/etc/init.d/multipathd
stop". I solved that if I changed the stop command to this one:
start-stop-daemon --stop --quiet --exec /sbin/multipathd

I have triend to add --retry 5 to KILL the process after 5 secs but it didn't
worked for me. Could you change it in the ebuild? Thanks.

------- Comment #5 From SpanKY 2006-11-09 16:44:50 0000 ------- 
works fine for me

------- Comment #6 From Jiri Tyr 2006-11-10 02:36:19 0000 ------- 
(In reply to comment #5)
> works fine for me

What works for you? My solition or current solution what is in the ebuild now?
What HW do you have?

------- Comment #7 From SpanKY 2006-11-12 21:10:12 0000 ------- 
using start/stop works for me ... i dont actually use device mapper

------- Comment #8 From Jiri Tyr 2006-11-13 00:50:53 0000 ------- 
OK, I vote for to replace old stop line in the init.d script with this one:
start-stop-daemon --stop --quiet --exec /sbin/multipathd

------- Comment #9 From SpanKY 2006-11-13 12:08:17 0000 ------- 
no ... it produces a pid file so we're going to use it

------- Comment #10 From Jiri Tyr 2006-11-14 00:45:18 0000 ------- 
(In reply to comment #9)
> no ... it produces a pid file so we're going to use it

But if the pid way doesn't work properly, then you sould switch to the exec
way. You sould search way how it works for everybody and not only for somebody!

------- Comment #11 From SpanKY 2006-11-14 16:06:02 0000 ------- 
except that it does

you're probably experiencing a bug that we've fixed elsewhere

in the meantime, change --pid to --pidfile in your local copy

------- Comment #12 From Jiri Tyr 2006-11-15 08:45:00 0000 ------- 
(In reply to comment #11)
> except that it does
> 
> you're probably experiencing a bug that we've fixed elsewhere
> 
> in the meantime, change --pid to --pidfile in your local copy
> 

Thank you. With "--pidfile" instead of the "--pid" it works very well. Would be
possible to change it in a portage?