Bug 148778 - net-libs/gnutls-1.4.4-r1 depends on sys-devel/gettext in non-nls build
Bug#: 148778 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: liquidx@gentoo.org Reported By: timo@kamph.org
Component: Ebuilds
URL: 
Summary: net-libs/gnutls-1.4.4-r1 depends on sys-devel/gettext in non-nls build
Keywords:  
Status Whiteboard: 
Opened: 2006-09-23 07:10 0000
Description:   Opened: 2006-09-23 07:10 0000 
Problem:
The gnutls-1.4.4-r1 ebuild unconditionally (r)depends on gettext, even if the
nls use flag is not set.

Solution:
The ebuild should check the nls use flag and only add sys-devel/gettext to
RDEPEND if the flag is set.

I'll attatch a fixed ebuild.

------- Comment #1 From Timo Kamph 2006-09-23 07:13:41 0000 ------- 
Created an attachment (id=97852) [details]
Fixed ebuild

------- Comment #2 From Timo Kamph 2006-09-23 07:17:39 0000 ------- 
Created an attachment (id=97854) [details]
Fix as patch

This is a diff between the original and the fixed ebuild file.

------- Comment #3 From Jakub Moc (RETIRED) 2006-09-23 07:18:57 0000 ------- 
(From update of attachment 97852 [details])
How exactly will this work? You didn't change anything except for adding the
use flag. 

You need $(use_enable nls) there (and no, I didn't check if it's even honored
by the build system).

------- Comment #4 From Jakub Moc (RETIRED) 2006-09-23 07:22:58 0000 ------- 
Plus gettext shouldn't be in RDEPEND:

RDEPEND="nls? ( virtual/libintl )
   ...."

DEPEND="${RDEPEND}
   nls? ( sys-devel/gettext )"

------- Comment #5 From Timo Kamph 2006-09-23 07:39:27 0000 ------- 
(In reply to comment #3)
> (From update of attachment 97852 [details] [edit])
> How exactly will this work? You didn't change anything except for adding the
> use flag. 

I added a check to RDEPEND, this is how it's done in other ebuilds and with the
other use flags in the gnutls ebuild. The important part of the fix is:

-       sys-devel/gettext"
+       nls? ( sys-devel/gettext )"

in RDEPEND=...

So please check it again.

------- Comment #6 From Timo Kamph 2006-09-23 07:41:52 0000 ------- 
(In reply to comment #4)
> Plus gettext shouldn't be in RDEPEND:
> 
> RDEPEND="nls? ( virtual/libintl )
>    ...."
> 
> DEPEND="${RDEPEND}
>    nls? ( sys-devel/gettext )"
> 

Well, I just want to get gettext out of my non-nls system.
Someone else put in into RDEPNED in the first place.

------- Comment #7 From Daniel Black 2006-09-23 15:16:13 0000 ------- 
by bad. Thanks Timo for bringing it to my attentioned. Problem should be fixed
now.