Bug 148593 - dev-games/irrlicht-1.1 patch for jpeg library mismatch
Bug#: 148593 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: games@gentoo.org Reported By: gentoobugzilla@manware.dk
Component: Games
URL: 
Summary: dev-games/irrlicht-1.1 patch for jpeg library mismatch
Keywords:  
Status Whiteboard: 
Opened: 2006-09-21 18:17 0000
Description:   Opened: 2006-09-21 18:17 0000
The irrlitch-1.1.ebuild use some of the lib files coming with irrlicht.

This gives problems when trying to run programs using jpeg files, e.g. the demo
(depending on the installed jpeg lib I guess)

From the ebuild file I can see that the intention is to use the gentoo lib
files for zlib jpeg and png, so I have made a patch to adopt that.

It consist of two parts.
1) Patching of two source files as mentioned by Kevin on the irrlicht forum.
This is in the irrlicht-1.1-jpeg.patch file.
2) Patching of the Makefile to not add the irrlicht own libs to the include
path. This is done by an extra line to the sed command.

After this it all works nicely.

For a perfect ebuild we should also patch the example makefiles to use correct
paths link the libs, but that must be some other time.
Maybe it could be an idea to just at a comment when emerging telling this.
For the demo program (the only one I have tried so far) the changes I made is
not added to my submitted ebuild, but the patch file is submitted.

I have also submitted info on the bug upstream to the irrlicht forums bug part:
http://irrlicht.sourceforge.net/phpBB2/viewtopic.php?p=89501

I am ofcourse willing to give any kind of missing information needed. Just let
me know.

-Sax

------- Comment #1 From Jesper Saxtorph 2006-09-21 18:19:34 0000 -------
Created an attachment (id=97715) [details]
patch file implementing the changes suggested by Kevin at the irrlicht forum

------- Comment #2 From Jesper Saxtorph 2006-09-21 18:21:26 0000 -------
Created an attachment (id=97716) [details]
Changed ebuild to include the jpeg patch file and added sed line for makefile
patch

------- Comment #3 From Jesper Saxtorph 2006-09-21 18:23:50 0000 -------
Created an attachment (id=97717) [details]
Patch to the demo makefile to make it compile on gentoo

------- Comment #4 From Tupone Alfredo 2006-10-14 04:30:10 0000 -------
Patches are now in portage
Thanks a lot