Bug 145941 - portage_overlay leaves behind overlay directory in squashfs and PORTDIR_OVERLAY in make.conf
Bug#: 145941 Product:  Gentoo Hosted Projects Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: catalyst@gentoo.org Reported By: agaffney@gentoo.org
Component: Catalyst
URL: 
Summary: portage_overlay leaves behind overlay directory in squashfs and PORTDIR_OVERLAY in make.conf
Keywords:  InSVN
Status Whiteboard: 
Opened: 2006-09-01 20:40 0000
Description:   Opened: 2006-09-01 20:40 0000 
I just booted up the x86 2006.1 LiveCD, and I've got the overlay for the
updated gentoo-sources in /root. On my local system, the overlay path was
/root/catalyst/overlays/portage. This is the exact path (contents included) on
the LiveCD. The PORTDIR_OVERLAY line is also in the LiveCD's /etc/make.conf.

------- Comment #1 From Andrew Gaffney 2006-09-01 20:48:09 0000 ------- 
In modules/generic_stage_target.py, it looks like the portage_overlay directory
is copied over with full path into the chroot. PORTDIR_OVERLAY is also added
directly to make.conf. At no point in this file is the PORTDIR_OVERLAY line
removed from make.conf or the copied overlay removed from the chroot.

I recommend setting PORTDIR_OVERLAY in the env instead of in make.conf. Also,
use a known temp dir for the overlay, so you can just remove the whole dir tree
when done without fear of killing something important. rsync the overlay to
/tmp/portage_overlay or some other known directory. Even if it's left around,
it won't be so obvious.

------- Comment #2 From Chris Gianelloni (RETIRED) 2006-09-03 13:38:54 0000 ------- 
Actually, I'm trying to move away from doing things in the environment only. 
Instead, we'll likely be copying the "hosts" idea and making a backup of
make.conf, then making changes to make.conf, then restoring the backup when
we're done.

------- Comment #3 From Jakub Moc (RETIRED) 2006-09-13 03:56:40 0000 ------- 
*** Bug 147430 has been marked as a duplicate of this bug. ***

------- Comment #4 From Chris Gianelloni (RETIRED) 2006-11-22 08:43:28 0000 ------- 
OK.  I lied.  The "best" solution that I can come up with here is to create a
new function to remove the overlay from make.conf and the directory.  I still
like the idea of putting it into a known location, though.

------- Comment #5 From Chris Gianelloni (RETIRED) 2007-01-09 14:53:07 0000 ------- 
This should be fixed in subversion now...

------- Comment #6 From Chris Gianelloni (RETIRED) 2007-02-06 22:53:50 0000 ------- 
Fixed in 2.0.2