Bug 142708 - ebuilds inheriting java-pkg, using pkg_setup() and not calling java-pkg_pkg_setup
Bug#: 142708 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: java@gentoo.org Reported By: caster@gentoo.org
Component: Ebuilds
URL: 
Summary: ebuilds inheriting java-pkg, using pkg_setup() and not calling java-pkg_pkg_setup
Keywords:  
Status Whiteboard: 
Opened: 2006-08-03 15:20 0000
Description:   Opened: 2006-08-03 15:20 0000 
Due to changes in Java handling in Gentoo, all packages inheriting java-pkg and
defining pkg_setup() must call java-pkg_pkg_setup from there to correctly
initialize java build environment. For packages that have java support USE-flag
based, this should be added:

use java && java-pkg_pkg_setup

to your pkg_setup()

Follows a list of ebuilds from current portage tree that inherit java-pkg,
define pkg_setup() but don't call java-pkg_pkg_setup yet. Maintainers can fix
them or let Java team do that.

app-accessibility/gnome-speech/gnome-speech-0.3.9.ebuild
app-accessibility/gnome-speech/gnome-speech-0.4.0.ebuild
app-accessibility/gnome-speech/gnome-speech-0.4.2.ebuild
app-accessibility/java-access-bridge/java-access-bridge-1.4.6.ebuild
app-accessibility/java-access-bridge/java-access-bridge-1.5.0.ebuild
dev-db/c-jdbc/c-jdbc-1.0.4-r1.ebuild
dev-db/hsqldb/hsqldb-1.7.3.1-r1.ebuild
dev-db/hsqldb/hsqldb-1.7.3.1-r2.ebuild
dev-db/postgresql/postgresql-7.3.15-r1.ebuild
dev-db/postgresql/postgresql-7.4.13.ebuild
dev-java/cairo-java/cairo-java-1.0.1.ebuild
dev-java/cairo-java/cairo-java-1.0.2.ebuild
dev-java/cairo-java/cairo-java-1.0.2-r1.ebuild
dev-java/glib-java/glib-java-0.2.1.ebuild
dev-java/glib-java/glib-java-0.2.2.ebuild
dev-java/glib-java/glib-java-0.2.3.ebuild
dev-java/glib-java/glib-java-0.2.3-r1.ebuild
dev-java/libgconf-java/libgconf-java-2.12.1.ebuild
dev-java/libgconf-java/libgconf-java-2.12.1-r1.ebuild
dev-java/libglade-java/libglade-java-2.12.1.ebuild
dev-java/libglade-java/libglade-java-2.12.2.ebuild
dev-java/libglade-java/libglade-java-2.12.2-r1.ebuild
dev-java/libgnome-java/libgnome-java-2.12.1.ebuild
dev-java/libgnome-java/libgnome-java-2.12.1-r1.ebuild
dev-java/libgtk-java/libgtk-java-2.8.1.ebuild
dev-java/libgtk-java/libgtk-java-2.8.2.ebuild
dev-java/libgtk-java/libgtk-java-2.8.3.ebuild
dev-java/libgtk-java/libgtk-java-2.8.3-r1.ebuild
dev-java/swt/swt-3.1-r1.ebuild
dev-java/velocity/velocity-1.4-r3.ebuild
dev-libs/cyrus-sasl/cyrus-sasl-2.1.21-r2.ebuild
dev-libs/cyrus-sasl/cyrus-sasl-2.1.22.ebuild
sci-libs/vtk/vtk-5.0.0.ebuild
www-apps/open-xchange/open-xchange-0.8.2.ebuild

------- Comment #1 From Vlastimil Babka (Caster) 2006-08-03 15:37:37 0000 ------- 
This was the command used to get this:

grep -rl --include='*.ebuild' "inherit.*java-pkg[^-]" /usr/portage/ | xargs
grep -l pkg_setup | xargs grep -L java-pkg_pkg_setup

------- Comment #2 From Leonardo Boshell (RETIRED) 2006-08-03 20:27:35 0000 ------- 
These have been modified accordingly:

  app-accessibility/gnome-speech
  app-accessibility/java-access-bridge

Thanks.

------- Comment #3 From Vlastimil Babka (Caster) 2006-08-05 03:35:09 0000 ------- 
There's a bit more stuff, missed due to bug in my search command, sorry (didn't
match ebuilds that had their inherit line ending with java-pkg). This is what
remains to be fixed after corrected search.

dev-db/c-jdbc/c-jdbc-1.0.4-r1.ebuild
dev-db/hsqldb/hsqldb-1.7.3.1-r1.ebuild
dev-db/hsqldb/hsqldb-1.7.3.1-r2.ebuild
dev-db/postgresql/postgresql-7.3.11.ebuild
dev-db/postgresql/postgresql-7.3.15-r1.ebuild
dev-db/postgresql/postgresql-7.4.13.ebuild
dev-java/cairo-java/cairo-java-1.0.1.ebuild
dev-java/cairo-java/cairo-java-1.0.2.ebuild
dev-java/cairo-java/cairo-java-1.0.2-r1.ebuild
dev-java/glib-java/glib-java-0.2.1.ebuild
dev-java/glib-java/glib-java-0.2.2.ebuild
dev-java/glib-java/glib-java-0.2.3.ebuild
dev-java/glib-java/glib-java-0.2.3-r1.ebuild
dev-java/jgroups/jgroups-2.2.7-r1.ebuild
dev-java/libgconf-java/libgconf-java-2.12.1.ebuild
dev-java/libgconf-java/libgconf-java-2.12.1-r1.ebuild
dev-java/libglade-java/libglade-java-2.12.1.ebuild
dev-java/libglade-java/libglade-java-2.12.2.ebuild
dev-java/libglade-java/libglade-java-2.12.2-r1.ebuild
dev-java/libgnome-java/libgnome-java-2.12.1.ebuild
dev-java/libgnome-java/libgnome-java-2.12.1-r1.ebuild
dev-java/libgtk-java/libgtk-java-2.8.1.ebuild
dev-java/libgtk-java/libgtk-java-2.8.2.ebuild
dev-java/libgtk-java/libgtk-java-2.8.3.ebuild
dev-java/libgtk-java/libgtk-java-2.8.3-r1.ebuild
dev-java/swt/swt-3.1-r1.ebuild
dev-java/swt/swt-3.2_pre1.ebuild
dev-java/velocity/velocity-1.4-r3.ebuild
dev-libs/cyrus-sasl/cyrus-sasl-2.1.20.ebuild
dev-libs/cyrus-sasl/cyrus-sasl-2.1.21-r2.ebuild
sci-libs/vtk/vtk-5.0.0.ebuild
www-apps/open-xchange/open-xchange-0.8.2.ebuild
www-servers/tomcat/tomcat-5.0.28-r12.ebuild
www-servers/tomcat/tomcat-5.5.17-r1.ebuild

plus ebuilds in java-experimental overlay:
java-experimental/www-servers/jetty/jetty-4.2.24.ebuild
java-experimental/www-servers/jetty/jetty-5.1.1.ebuild
java-experimental/www-servers/jetty/jetty-5.1.1-r1.ebuild
java-experimental/www-servers/jetty/jetty-5.1.3.ebuild
java-experimental/www-servers/tomcat/tomcat-5.0.28-r15.ebuild
java-experimental/www-servers/tomcat/tomcat-5.5.17-r4.ebuild
java-experimental/www-servers/tomcat/tomcat-5.5.9.ebuild

------- Comment #4 From Vlastimil Babka (Caster) 2006-09-14 14:26:46 0000 ------- 
Updated list:
./sci-libs/vtk/vtk-5.0.0.ebuild
./dev-db/postgresql/postgresql-7.3.15-r1.ebuild
./dev-db/postgresql/postgresql-7.4.13.ebuild
./dev-db/postgresql/postgresql-7.3.11.ebuild
./media-libs/ming/ming-0.3.0.ebuild
./www-servers/tomcat/tomcat-5.0.28-r12.ebuild
./www-servers/tomcat/tomcat-5.0.28-r13.ebuild
./dev-java/swt/swt-3.1-r1.ebuild
./dev-java/libgtk-java/libgtk-java-2.8.2.ebuild
./dev-java/libgtk-java/libgtk-java-2.8.1.ebuild
./dev-java/libgtk-java/libgtk-java-2.8.3-r1.ebuild
./dev-java/libgtk-java/libgtk-java-2.8.3.ebuild
./dev-java/velocity/velocity-1.4-r3.ebuild
./dev-java/glib-java/glib-java-0.2.3.ebuild
./dev-libs/cyrus-sasl/cyrus-sasl-2.1.21-r2.ebuild
./www-apps/open-xchange/open-xchange-0.8.2.ebuild


java-experimental-overlay/www-servers/jetty/jetty-5.1.3.ebuild
java-experimental-overlay/www-servers/jetty/jetty-5.1.1-r1.ebuild
java-experimental-overlay/www-servers/jetty/jetty-4.2.24.ebuild
java-experimental-overlay/www-servers/jetty/jetty-5.1.1.ebuild
java-experimental-overlay/www-servers/tomcat/tomcat-5.5.9.ebuild

------- Comment #5 From Josh Nichols (RETIRED) 2006-10-13 17:19:51 0000 ------- 
* Fixed vtk.
* Postgres doesn't need to be fixed because there are newer version in same
slot that are fixed.
* Ming seems to be a false positive.
* Fixed tomcat.
* Fixed swt
* Fixed libgtk-java
* Fixed velocity
* glib-java was previously fixed
* newer revision of cyrus-sasl is fixed
* Fixed open-xchange.

As for the things in the overlay, those ebuild will be going away or have done
so already, so I"m not going to worry about them.

Marking fixed.