| Summary: | media-video/ogmrip spooky pkg_setup() | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jakub Moc (RETIRED) <jakub> |
| Component: | New packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | ||
| Priority: | Highest | ||
| Version: | 2006.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
ogmrip-0.9.0-r2.ebuild.diff
An updated version of the patch |
||
Created attachment 93074 [details, diff]
ogmrip-0.9.0-r2.ebuild.diff
- fix pkg_setup()
- add quoting
- do not dodoc COPYING INSTALL
Created attachment 94473 [details, diff]
An updated version of the patch
Added this to ogmrip-0.9.0-r1.ebuild. |
<snip> pkg_setup() { if ! which mencoder > /dev/null 2>&1; then eerror "Unable to find mencoder in the PATH. You need mencoder to use OGMRip." eerror "Please, add encode to your USE flags and emerge mplayer again." die "Unable to find mencoder in the PATH. You need mencoder to use OGMRip." fi if ! mencoder -ovc help 2> /dev/null | grep -q "^ *xvid *- .*$"; then echo eerror "Mplayer is not build with XviD support. OGMRip requires XviD support in mplayer." eerror "Please, add xvid to your USE flags and emerge mplayer again." die "Mplayer is not build with XviD support. OGMRip requires XviD support in mplayer." fi } </snip> Err... 1/ mplayer is in RDEPEND, why would one miss mencoder? What are you after here? 2/ Use built_with_use check from eutils eclass, perhaps?