Summary: | kernel bug in 2.6.17-gentoo-r4: xirc2ps_cs do_reset uses msleep | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jörg Ahrens <joerg> |
Component: | [OLD] Core system | Assignee: | Daniel Drake (RETIRED) <dsd> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kernel |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch against 2.6.17-gentoo-r4
corrected patch against 2.6.17-gentoo-r4 patch against 2.6.17-gentoo-r4 |
Description
Jörg Ahrens
2006-07-29 07:31:51 UTC
Created attachment 93003 [details, diff]
patch against 2.6.17-gentoo-r4
Looks good, but the work structure should be initialised during xirc2ps_probe rather than when the interface is brought up. Can you correct the patch? Also the ugly (void (*)(void *)) casts are not needed Created attachment 94275 [details, diff]
corrected patch against 2.6.17-gentoo-r4
of course we could get rid of the #ifdef HAVE_TX_TIMEOUT too
Why have you added the extra changes? do_tx_timeout is not used unless HAVE_TX_TIMEOUT is defined, so no need to provide the "alternate version". As it is static, the compiler will remove it if HAVE_TX_TIMEOUT is not defined (but it always will be). Just provide xirc2ps_tx_timeout_task in similar fashion. Also, tx_errors should be incremented immediately, not when the workqueue gets around to scheduling the task. Created attachment 94565 [details, diff]
patch against 2.6.17-gentoo-r4
You are right, the additional conditional stuff is crap.
The forward declaration of xirc2ps_tx_timeout_task is necessary as INIT_WORK
went down.
I changed the argument of xirc2ps_tx_timeout_task to what it is supposed to be
to avoid a a compile warning at INIT_WORK.
As a consequence I inserted the local variable *dev in xirc2ps_tx_timeout_task
to avoid two type casts.
I hope it's OK now.
thanks, sent upstream This is now merged into Linus' tree for 2.6.18-rc6 or 2.6.18 (depending which comes next!) Fixed in gentoo-sources-2.6.17-r8 (genpatches-2.6.17-10). Thanks for the patch. |